From: Robert Love <rml@novell.com>
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] Fix inotify umount hangs.
Date: Tue, 05 Jul 2005 11:20:04 -0400 [thread overview]
Message-ID: <1120576805.6745.197.camel@betsy> (raw)
In-Reply-To: <Pine.LNX.4.60.0507042009170.7572@hermes-1.csi.cam.ac.uk>
On Mon, 2005-07-04 at 20:28 +0100, Anton Altaparmakov wrote:
> The below patch against 2.6.13-rc1-mm1 fixes the umount hangs caused by
> inotify.
Thank you, very much, Anton, for hacking on this over the weekend.
It's definitely not the prettiest thing, but there may be no easier
approach. One thing, the messy code is working around the list
changing, doesn't invalidate_inodes() have the same problem? If so, it
solves it differently.
I'm also curious if the I_WILL_FREE or i_count check fixed the bug. I
suspect the other fix did, but we probably still want this. Or at least
the I_WILL_FREE check.
Anyhow... I'll send out an updated inotify patch after some testing.
Thanks again.
Robert Love
next prev parent reply other threads:[~2005-07-05 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-04 19:28 [-mm patch] Fix inotify umount hangs Anton Altaparmakov
2005-07-05 15:20 ` Robert Love [this message]
2005-07-05 17:03 ` Anton Altaparmakov
2005-07-05 17:11 ` Anton Altaparmakov
2005-07-05 20:43 ` Anton Altaparmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1120576805.6745.197.camel@betsy \
--to=rml@novell.com \
--cc=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox