Re: [PATCH] [29/48] Suspend2 2.1.9.8 for 2.6.12: 606-all-settings.patch

Nigel Cunningham
2005-07-11T09:36:49Z

Hi.

On Mon, 2005-07-11 at 04:03, Pavel Machek wrote:
> Hi!
>
> > +static void suspend2_suspend_2(void)
> > +{
> > + if (!save_image_part1()) {
> > + suspend_power_down();
> > +
> > + if (suspend2_powerdown_method == 3) {
> > + int temp_result;
> > +
> > + temp_result = read_pageset2(1);
>
>
> Is that just me or do I see way too many numbers. suspend2_suspend_2
> is really funny name for a functions. powerdown_method should really
> use some symbolic constants.

No, it's not just you. It's one of those hangovers from the original
code that I hadn't gotten around to cleaning up.

Symbolic constants now in place for the powerdown method too.

Regards,

Nigel
--
Evolution.
Enumerate the requirements.
Consider the interdependencies.
Calculate the probabilities.
Be amazed that people believe it happened.