Re: [PATCH] [28/48] Suspend2 2.1.9.8 for 2.6.12: 605-kernel_power_suspend.patch

Nigel Cunningham
2005-07-12T08:40:12Z

Hi.

On Mon, 2005-07-11 at 03:58, Pavel Machek wrote:
> Hi!
>
> > diff -ruNp 606-all-settings.patch-old/kernel/power/suspend2_core/all_settings.c 606-all-settings.patch-new/kernel/power/suspend2_core/all_settings.c
> > --- 606-all-settings.patch-old/kernel/power/suspend2_core/all_settings.c 1970-01-01 10:00:00.000000000 +1000
> > +++ 606-all-settings.patch-new/kernel/power/suspend2_core/all_settings.c 2005-07-04 23:14:19.000000000 +1000

[...]

> > + * This entry allows all of the settings to be set at once.
> > + * It was originally for compatibility with pre- /proc/suspend
> > + * versions, but has been retained because it makes saving and
> > + * restoring the configuration simpler.
> > + */
>
> Okay, and it is also extremely ugly. Now you have chance to clean it
> up, please drop it.

After checking with users, done.

Regards,

Nigel
--
Evolution.
Enumerate the requirements.
Consider the interdependencies.
Calculate the probabilities.
Be amazed that people believe it happened.