From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933542AbcLIOgc (ORCPT ); Fri, 9 Dec 2016 09:36:32 -0500 Received: from mout.web.de ([217.72.192.78]:51100 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932594AbcLIOga (ORCPT ); Fri, 9 Dec 2016 09:36:30 -0500 Subject: [PATCH 2/4] staging: greybus: light: Use kcalloc() in two functions To: devel@driverdev.osuosl.org, Alex Elder , Greg Kroah-Hartman , Johan Hovold , Rui Miguel Silva References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <112064ca-41b3-6936-090a-3c229a251af7@users.sourceforge.net> Date: Fri, 9 Dec 2016 15:36:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:cIcbQtiR77aR/DF/kuHcCgkyzBwO8mRUEIyAzO+Dyq5+2O4qLKr UlrOSIhD/1ttShLuyj84upnAycmO9aJqGztPf2JIgmZ1I/c1nNvo0VO/kNDkN6qN2lRBA5z v7vvnp7oln6DECPikSptz20UMpHabRJVjWdWuddkUa20VGF/NtAV52QFPzFE9kH5jBZRoQv brTrCmWcXh+Owgrb7QkKw== X-UI-Out-Filterresults: notjunk:1;V01:K0:gKm6ZXfIuk0=:FsS6byX2Fb7Ir2CNkHJbuD vu2C0GAGq9T8159S/yDy1+s9/Y5q5X8MwDvLHaoHgdV5TATpX8AQt5cwxiZJ7unHnMQRi46uT eFmktaUjb71LmP0l0FCh9+seBpBYQizLdbN5JwP1nsShWvY4i4BO2C+9d5lVOeZ0hkw34S63/ SCKJXUFxzCHsLrUAeU4x98qskwPToFp3cZnGanZUV4dOr3EYBMuTPyWQdmdAm/OA6nZ19t4LA F8JWWPowcuxfL1zfRJh7DO/a5odt4zO2cWCGTNS5OLi2brqEUHF1KhnZRK+72wHrS24SQn1x7 JFBy5QFy9ErBai2y8FcHCw+M1FuQdmjA59ihlZOcdtocEQus2gfwRZJXTpHZrMMVE7Koh7cFJ EwCkJocwf1lq9Yf7IduHwD61uncyjsZ28NY+7j6LzIkVIjC0R02V8XQTjCC8R6oia+pFsfiTm Nl6OdNTtECmE9gQeajLtPAaei3wIWOmXL7jCG2q6dywR2XCfRo3VZKcoCg7TKfTq7e85siEUU K4PmDSUr4Gf8j9jyIQmj99OIMz7VdC0Dw6ikBdWw0QIDomwbGO0Itaa9JOD6U6s1X6KFiN2Ih sYvzjNFNv/20gXt4hQQU9ZxiaTgASa9KAsiUf8+FFuGp7scxUu+NqNOXJG9nlTHuRZMObiC3Q pn9+6Kv4LWixIRrJ+8Ry0SAF+2oTXLIOMtT1QBmVIUom2Gh4EURw55PnoAtNdY4qaNbH4L/Zt K//C1s5mCZxc+RQIlCkxN90+4Iu6+2/SISmnAvNrLR2NkG5zU+19IvPV4pFgKQKIiNS4+ksYw SzIY/vu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 9 Dec 2016 13:46:25 +0100 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of data structures by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. Fixes: 2870b52bae4c81823ffcb3ed2b0626fb39d64f48 ("greybus: lights: add lights implementation") Signed-off-by: Markus Elfring --- drivers/staging/greybus/light.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 8dffd8a7e762..27bfc20eb9a5 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -1030,9 +1030,9 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id) light->channels_count = conf.channel_count; light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL); - - light->channels = kzalloc(light->channels_count * - sizeof(struct gb_channel), GFP_KERNEL); + light->channels = kcalloc(light->channels_count, + sizeof(*light->channels), + GFP_KERNEL); if (!light->channels) return -ENOMEM; @@ -1168,8 +1168,9 @@ static int gb_lights_create_all(struct gb_lights *glights) if (ret < 0) goto out; - glights->lights = kzalloc(glights->lights_count * - sizeof(struct gb_light), GFP_KERNEL); + glights->lights = kcalloc(glights->lights_count, + sizeof(*glights->lights), + GFP_KERNEL); if (!glights->lights) { ret = -ENOMEM; goto out; -- 2.11.0