From: Alexander Nyberg <alexn@telia.com>
To: Rudo Thomas <rudo@matfyz.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.12.2 -- time passes faster; related to the acpi_register_gsi() call
Date: Fri, 08 Jul 2005 23:25:08 +0200 [thread overview]
Message-ID: <1120857908.25294.33.camel@localhost.localdomain> (raw)
In-Reply-To: <20050708211203.GC382@ss1000.ms.mff.cuni.cz>
fre 2005-07-08 klockan 23:12 +0200 skrev Rudo Thomas:
> Hello, guys.
>
> Time started to pass faster with 2.6.12.2 (actually, it was 2.6.12-ck3
> which is based on it). I have isolated the cause of the problem:
I bet you this fixes it (already in mainline)
tree e6a38b3d6bf434f08054562113bb660c4227769f
parent 4a89a04f1ee21a7c1f4413f1ad7dcfac50ff9b63
author Linus Torvalds <torvalds@g5.osdl.org> Sun, 03 Jul 2005 00:35:33 -0700
committer Linus Torvalds <torvalds@g5.osdl.org> Sun, 03 Jul 2005 00:35:33 -0700
If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq.
That zero just means that nothing else found any irq information either.
drivers/acpi/pci_irq.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -433,7 +433,7 @@ acpi_pci_irq_enable (
printk(KERN_WARNING PREFIX "PCI Interrupt %s[%c]: no GSI",
pci_name(dev), ('A' + pin));
/* Interrupt Line values above 0xF are forbidden */
- if (dev->irq >= 0 && (dev->irq <= 0xF)) {
+ if (dev->irq > 0 && (dev->irq <= 0xF)) {
printk(" - using IRQ %d\n", dev->irq);
acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
return_VALUE(0);
next prev parent reply other threads:[~2005-07-08 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 21:12 2.6.12.2 -- time passes faster; related to the acpi_register_gsi() call Rudo Thomas
2005-07-08 21:25 ` Alexander Nyberg [this message]
2005-07-08 22:03 ` Phil Oester
2005-07-08 22:27 ` Lee Revell
2005-07-08 22:57 ` Chris Wright
2005-07-08 23:08 ` Rudo Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1120857908.25294.33.camel@localhost.localdomain \
--to=alexn@telia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rudo@matfyz.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox