From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933216AbcJQWaX (ORCPT ); Mon, 17 Oct 2016 18:30:23 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:64495 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755138AbcJQWaR (ORCPT ); Mon, 17 Oct 2016 18:30:17 -0400 From: Arnd Bergmann To: Patrick Farrell Cc: Oleg Drokin , "devel@driverdev.osuosl.org" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Linus Torvalds , "lustre-devel@lists.lustre.org" Subject: Re: [lustre-devel] [PATCH 08/28] staging: lustre: restore initialization of return code Date: Tue, 18 Oct 2016 00:29:59 +0200 Message-ID: <11209173.masZYIyEty@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <20161017220342.1627073-1-arnd@arndb.de> <20161017220903.1746743-2-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:xk2PD9t/Emd6nmSnl+LaN3rKu1NwJuaPdo8ca9SpkgT6zB2JzkR 6Nvd23MwRX9hnhQtCo8fGFQGqE7/98r9wTkcfS9Lv7/uMJAYFjkpzr+yvNZH8C5I9RiDJBp qUMya71GxYfYp9MgcKsf8M4B//q9maoUm83urj5SCbCLrK7/fm4Dvbr0N1GNlY/XFm1SzpG BfcF6OfMOqU+vtVkxTvRg== X-UI-Out-Filterresults: notjunk:1;V01:K0:ClQo23Kt6n4=:RUMfmzOopm8F9GQNzyNHsZ /ulnoi1Eeqm2jgBhI3hWlXPvQ/WxX9mG7EUc/76vnR5uEoItY9TU/sI4sTmvXLNQMJ1nLFeBB dwJeZEqzGIJjeFWeE1DaGLeglk5zqL7fHhxbtoM3BLP/LJHHgHE7aGFXISnQOZOnYH9U85tCu 0uNnNqF1qTqCU43ZrJYsr+7hI98e+uEIXpn6x+R5l9wf41LZUXaaokmZq8wusyT8/0alSMbag 78tMSCpoYuOiwdLqD1UnBaiC/EKiAPP8HV8NCm09ZA3UZirwST0ADSQx20f4Q6sxsI7bQCwg0 AP6jGoebWDpLUHawfUsDH4taaSQeBlnfBzMLo2ONrXX7aRgxGc/DtYZ5IVXaj7+GPIpfTximW f4og4kWdaSNY4S1VlgIgnzncrfveyo1DtZxQeX/bEwdwftrgaNGhuRkbATydd8JRTgmGCqWVx 5b5jWdSI7R3QKEWGYAwao2Dtgi6W7F1JMBSez6aCu+xFxAE82ftgJnJTVZTMujBIWTEA9LJXC ZMTSnhcNrw6qLtcuJYALMSaymy76946zs/E3dmyChOUXmM1IxYLcCL6cyseyXIFt/TkCJeUIf A59W6ZcSOBJ05ruSenBq2kxBoJQk9gqj465P5yNwhkg4H61mMuvxhB+jDl2MUrnvn96GS180x JTGdxUzvabAyajwxjp/A9nHwdGhX2SFfYKHY5Zl4TMdCMgB2WVG3gb6k1neK8mXmxhoetsRMn 4BWqYAszZQEl5IvB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, October 17, 2016 10:23:00 PM CEST Patrick Farrell wrote: > Arnd, > > > The description and the actual patch don't seem to match up. Am I missing something? Sorry, I pasted the wrong error message when writing the changelog. > From: lustre-devel on behalf of Arnd Bergmann > Sent: Monday, October 17, 2016 5:08:55 PM > To: Oleg Drokin > Cc: devel@driverdev.osuosl.org; Arnd Bergmann; Greg Kroah-Hartman; linux-kernel@vger.kernel.org; Linus Torvalds; lustre-devel@lists.lustre.org > Subject: [lustre-devel] [PATCH 08/28] staging: lustre: restore initialization of return code > > A recent rework removed the initialization of the successful return > code from lpfc_write_firmware: > > drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_write_firmware': > drivers/scsi/lpfc/lpfc_init.c:10333:214: error: format '%ld' expects argument of type 'long int', but argument 9 has type 'size_t {aka const unsigned int}' [-Werror=format=] > > This adds it back. It should have been this warning: drivers/staging/lustre/lustre/lov/lov_pack.c: In function 'lov_getstripe': drivers/staging/lustre/lustre/lov/lov_pack.c:426:9: error: 'rc' may be used uninitialized in this function [-Werror=maybe-uninitialized] return rc; ^~ drivers/staging/lustre/lustre/lov/lov_pack.c:313:6: note: 'rc' was declared here Arnd