From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262015AbVGKSLQ (ORCPT ); Mon, 11 Jul 2005 14:11:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262065AbVGKSLG (ORCPT ); Mon, 11 Jul 2005 14:11:06 -0400 Received: from mailgw.voltaire.com ([212.143.27.70]:62663 "EHLO mailgw.voltaire.com") by vger.kernel.org with ESMTP id S262015AbVGKPiA (ORCPT ); Mon, 11 Jul 2005 11:38:00 -0400 Subject: Re: [PATCH 3/27] Add MAD helper functions From: Hal Rosenstock To: Alexey Dobriyan Cc: Andrew Morton , linux-kernel@vger.kernel.org, openib-general@openib.org In-Reply-To: <200507111839.41807.adobriyan@gmail.com> References: <1121089079.4389.4511.camel@hal.voltaire.com> <200507111839.41807.adobriyan@gmail.com> Content-Type: text/plain Organization: Message-Id: <1121094791.4389.4591.camel@hal.voltaire.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 (1.2.2-4) Date: 11 Jul 2005 11:30:23 -0400 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: > On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > > Add new helper routines for allocating MADs for sending and formatting > > a send WR. > > > -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c > > +++ linux-2.6.13-rc2-mm1/drivers/infiniband3/core/mad.c > ^^^^^^^^^^^ > Ick. You'd better have linux-2.6.13-rc2-mm1-[0123...]. Shall I resubmit with linux-2.6.13-rc2-mm1-[0123...] ? > > +struct ib_mad_send_buf * ib_create_send_mad(struct ib_mad_agent *mad_agent, > > + u32 remote_qpn, u16 pkey_index, > > + struct ib_ah *ah, > > + int hdr_len, int data_len, > > + int gfp_mask) > > unsigned int __nocast gfp_mask, please. 430 or so infiniband sparse warnings > is not a reason to add more. I'll fix this in a subsequent patch. Is that OK ? Thanks. -- Hal