From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Cc: khali@linux-fr.org
Subject: [PATCH] I2C: m41t00: fix incorrect kfree
Date: Mon, 11 Jul 2005 15:02:56 -0700 [thread overview]
Message-ID: <1121119376361@kroah.com> (raw)
In-Reply-To: <11211193763732@kroah.com>
[PATCH] I2C: m41t00: fix incorrect kfree
Here is a simple path fixing an incorrect kfree in the m41t00 i2c chip
driver. The current code happens to work by accident, but the freed
pointer isn't the one which was allocated in the first place, which
could cause problems later.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
commit 5da69ba42aa42a479c0f5d8cb8351ebb6b51c12e
tree 3a0f32c3fbc961bb5f6b39c22c573fa8acd7c443
parent 2146fec20c38d926f0d88413977f941f42a14588
author Jean Delvare <khali@linux-fr.org> Fri, 01 Jul 2005 14:28:15 +0200
committer Greg Kroah-Hartman <gregkh@suse.de> Mon, 11 Jul 2005 14:10:36 -0700
drivers/i2c/chips/m41t00.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/chips/m41t00.c b/drivers/i2c/chips/m41t00.c
--- a/drivers/i2c/chips/m41t00.c
+++ b/drivers/i2c/chips/m41t00.c
@@ -207,7 +207,7 @@ m41t00_detach(struct i2c_client *client)
int rc;
if ((rc = i2c_detach_client(client)) == 0) {
- kfree(i2c_get_clientdata(client));
+ kfree(client);
tasklet_kill(&m41t00_tasklet);
}
return rc;
next prev parent reply other threads:[~2005-07-11 22:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-11 22:01 [GIT PATCH] I2C patches for 2.6.13-rc2 Greg KH
2005-07-11 22:02 ` [PATCH] I2C: max6875 documentation update Greg KH
2005-07-11 22:02 ` [PATCH] I2C: max6875 Kconfig update Greg KH
2005-07-11 22:02 ` [PATCH] I2C: drop bogus eeprom comment Greg KH
2005-07-11 22:02 ` [PATCH] I2C: Strip trailing whitespace from strings Greg KH
2005-07-11 22:02 ` Greg KH [this message]
2005-07-11 22:02 ` [PATCH] I2C: Coding style cleanups to via686a Greg KH
2005-07-11 22:02 ` [PATCH] I2C: minor TPS6501x cleanups Greg KH
2005-07-11 22:02 ` [PATCH] I2C: New max6875 driver may corrupt EEPROMs Greg KH
2005-07-11 22:02 ` [PATCH] i2c: make better use of IDR in i2c-core Greg KH
2005-07-11 22:02 ` [PATCH] w1: fix CRC calculation on bigendian platforms Greg KH
2005-07-11 22:02 ` [PATCH] I2C: Clarify the usage of i2c-dev.h Greg KH
2005-07-11 22:02 ` [PATCH] I2C: minor I2C doc cleanups Greg KH
2005-07-11 22:02 ` [PATCH] I2C: SENSORS_ATXP1 must select I2C_SENSOR Greg KH
2005-07-11 22:02 ` [PATCH] I2C: Documentation fix Greg KH
2005-07-11 22:02 ` [PATCH] I2C: Move hwmon drivers (1/3) Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1121119376361@kroah.com \
--to=gregkh@suse.de \
--cc=greg@kroah.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox