public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Cc: david-b@pacbell.net
Subject: [PATCH] I2C: minor I2C doc cleanups
Date: Mon, 11 Jul 2005 15:02:57 -0700	[thread overview]
Message-ID: <11211193771521@kroah.com> (raw)
In-Reply-To: <1121119377583@kroah.com>

[PATCH] I2C: minor I2C doc cleanups

The I2C stack has long had "id" fields, of rather dubious utility, in
many data structures.  This removes mention of one of them from the
documentation about how to write an I2C driver, so that only drivers
that really need to use them (probably old/legacy code) will have any
reason to use this field.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
commit 61f5809d3ebce9d5433b8696048e91405b681023
tree bcb41c29d36b3b6f84d34c7bac05b38855e90742
parent 2db32767874fe53faff4f80de878ca19927efc1f
author david-b@pacbell.net <david-b@pacbell.net> Wed, 29 Jun 2005 07:14:06 -0700
committer Greg Kroah-Hartman <gregkh@suse.de> Mon, 11 Jul 2005 14:10:37 -0700

 Documentation/i2c/writing-clients |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/Documentation/i2c/writing-clients b/Documentation/i2c/writing-clients
--- a/Documentation/i2c/writing-clients
+++ b/Documentation/i2c/writing-clients
@@ -27,7 +27,6 @@ address.
 static struct i2c_driver foo_driver = {
 	.owner		= THIS_MODULE,
 	.name		= "Foo version 2.3 driver",
-	.id		= I2C_DRIVERID_FOO, /* from i2c-id.h, optional */
 	.flags		= I2C_DF_NOTIFY,
 	.attach_adapter	= &foo_attach_adapter,
 	.detach_client	= &foo_detach_client,
@@ -37,12 +36,6 @@ static struct i2c_driver foo_driver = {
 The name can be chosen freely, and may be upto 40 characters long. Please
 use something descriptive here.
 
-If used, the id should be a unique ID. The range 0xf000 to 0xffff is
-reserved for local use, and you can use one of those until you start
-distributing the driver, at which time you should contact the i2c authors
-to get your own ID(s). Note that most of the time you don't need an ID
-at all so you can just omit it.
-
 Don't worry about the flags field; just put I2C_DF_NOTIFY into it. This
 means that your driver will be notified when new adapters are found.
 This is almost always what you want.


  reply	other threads:[~2005-07-11 22:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-11 22:01 [GIT PATCH] I2C patches for 2.6.13-rc2 Greg KH
2005-07-11 22:02 ` [PATCH] I2C: max6875 documentation update Greg KH
2005-07-11 22:02   ` [PATCH] I2C: max6875 Kconfig update Greg KH
2005-07-11 22:02     ` [PATCH] I2C: drop bogus eeprom comment Greg KH
2005-07-11 22:02       ` [PATCH] I2C: Strip trailing whitespace from strings Greg KH
2005-07-11 22:02         ` [PATCH] I2C: m41t00: fix incorrect kfree Greg KH
2005-07-11 22:02           ` [PATCH] I2C: Coding style cleanups to via686a Greg KH
2005-07-11 22:02             ` [PATCH] I2C: minor TPS6501x cleanups Greg KH
2005-07-11 22:02               ` [PATCH] I2C: New max6875 driver may corrupt EEPROMs Greg KH
2005-07-11 22:02                 ` [PATCH] i2c: make better use of IDR in i2c-core Greg KH
2005-07-11 22:02                   ` [PATCH] w1: fix CRC calculation on bigendian platforms Greg KH
2005-07-11 22:02                     ` [PATCH] I2C: Clarify the usage of i2c-dev.h Greg KH
2005-07-11 22:02                       ` Greg KH [this message]
2005-07-11 22:02                         ` [PATCH] I2C: SENSORS_ATXP1 must select I2C_SENSOR Greg KH
2005-07-11 22:02                           ` [PATCH] I2C: Documentation fix Greg KH
2005-07-11 22:02                             ` [PATCH] I2C: Move hwmon drivers (1/3) Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11211193771521@kroah.com \
    --to=gregkh@suse.de \
    --cc=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox