From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263315AbVGOPOJ (ORCPT ); Fri, 15 Jul 2005 11:14:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263330AbVGOPOI (ORCPT ); Fri, 15 Jul 2005 11:14:08 -0400 Received: from yacht.ocn.ne.jp ([222.146.40.168]:50882 "EHLO smtp.yacht.ocn.ne.jp") by vger.kernel.org with ESMTP id S263315AbVGOPOE (ORCPT ); Fri, 15 Jul 2005 11:14:04 -0400 Subject: Re: [PATCH] mb_cache_shrink() frees unexpected caches From: Akinobu Mita To: Andreas Gruenbacher Cc: Andrew Morton , linux-kernel@vger.kernel.org In-Reply-To: <200507151636.27532.agruen@suse.de> References: <1121346444.4282.8.camel@localhost.localdomain> <200507151249.52294.agruen@suse.de> <1121434894.1261.4.camel@localhost.localdomain> <200507151636.27532.agruen@suse.de> Content-Type: text/plain Date: Sat, 16 Jul 2005 00:07:46 +0900 Message-Id: <1121440067.4137.2.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org 2005-07-15 (Fri) 16:36 +0200 Andreas Gruenbacher wrote: > The cache parameter could indeed be removed. Not that it would matter much... > Currently, mbcache is used only for xattr on ext2/ext3 and reiserfs. In other words, only one type of mbcache is used per-filesystem. So any problems don't happen without the patch I sent. But, for example when someone use mbcache as another purpose on ext3, The crash will be caused by using mb_cache_shrink(). Therefore, I think your patch should not be committed until mbcache will be limited to use only type per-filesystem.