public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@rpsys.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@osdl.org>,
	lenz@cs.wisc.edu, linux-kernel@vger.kernel.org
Subject: Re: [patch] Support powering sharp zaurus sl-5500 LCD up and down
Date: Wed, 27 Jul 2005 11:06:09 +0100	[thread overview]
Message-ID: <1122458769.7773.39.camel@localhost.localdomain> (raw)
In-Reply-To: <20050727095324.GE4270@elf.ucw.cz>

On Wed, 2005-07-27 at 11:53 +0200, Pavel Machek wrote: 
> +	/* read comadj */
> +#ifdef CONFIG_MACH_POODLE
> +	comadj = 118;
> +#else
> +	comadj = 128;
> +#endif

Can you go back to the Sharp source and confirm that these values should
be hardcoded in both the poodle and collie cases please? I know the
sharpsl_param code can provide them but I can't remember exactly which
models use which fields. I want to make sure this isn't a quick hack
John made before sharpsl_param was written :).

Thanks,

Richard


  reply	other threads:[~2005-07-27 10:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-27  9:26 [patch] Support powering sharp zaurus sl-5500 LCD up and down Pavel Machek
2005-07-27  9:37 ` Andrew Morton
2005-07-27  9:50   ` Pavel Machek
2005-07-27 10:00     ` Andrew Morton
2005-07-27 10:05       ` Pavel Machek
2005-07-27  9:53   ` Pavel Machek
2005-07-27 10:06     ` Richard Purdie [this message]
2005-07-30 13:07       ` Pavel Machek
2005-08-01 21:23       ` John Lenz
2005-08-01 22:14         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1122458769.7773.39.camel@localhost.localdomain \
    --to=rpurdie@rpsys.net \
    --cc=akpm@osdl.org \
    --cc=lenz@cs.wisc.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox