* [patch] inotify: ppc32 syscalls.
@ 2005-07-27 15:45 Robert Love
2005-07-27 16:55 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Robert Love @ 2005-07-27 15:45 UTC (permalink / raw)
To: paulus; +Cc: Linux Kernel Mailing List, Andrew Morton, The Cutch
Hey, Paulus,
Add inotify system call stubs to PPC32.
Signed-off-by: Robert Love <rml@novell.com>
arch/ppc/kernel/misc.S | 3 +++
include/asm-ppc/unistd.h | 5 ++++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc3-git8/arch/ppc/kernel/misc.S linux/arch/ppc/kernel/misc.S
--- linux-2.6.13-rc3-git8/arch/ppc/kernel/misc.S 2005-07-27 10:59:31.000000000 -0400
+++ linux/arch/ppc/kernel/misc.S 2005-07-27 11:25:43.000000000 -0400
@@ -1451,3 +1451,6 @@
.long sys_waitid
.long sys_ioprio_set
.long sys_ioprio_get
+ .long sys_inotify_init /* 275 */
+ .long sys_inotify_add_watch
+ .long sys_inotify_rm_watch
diff -urN linux-2.6.13-rc3-git8/include/asm-ppc/unistd.h linux/include/asm-ppc/unistd.h
--- linux-2.6.13-rc3-git8/include/asm-ppc/unistd.h 2005-07-27 10:59:32.000000000 -0400
+++ linux/include/asm-ppc/unistd.h 2005-07-27 11:25:26.000000000 -0400
@@ -279,8 +279,11 @@
#define __NR_waitid 272
#define __NR_ioprio_set 273
#define __NR_ioprio_get 274
+#define __NR_inotify_init 275
+#define __NR_inotify_add_watch 276
+#define __NR_inotify_rm_watch 277
-#define __NR_syscalls 275
+#define __NR_syscalls 278
#define __NR(n) #n
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] inotify: ppc32 syscalls.
2005-07-27 15:45 [patch] inotify: ppc32 syscalls Robert Love
@ 2005-07-27 16:55 ` Andrew Morton
2005-07-27 17:31 ` [patch] inotify: ppc64 syscalls Robert Love
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2005-07-27 16:55 UTC (permalink / raw)
To: Robert Love; +Cc: paulus, linux-kernel, ttb
Robert Love <rml@novell.com> wrote:
>
> Hey, Paulus,
>
> Add inotify system call stubs to PPC32.
>
ppc64 likes to keep its 32-bit-syscall table in sync with ppc32 so it'd be
best to do ppc64 while we're at it (both sys_call_table and
sys_call_table32)
>
> arch/ppc/kernel/misc.S | 3 +++
> include/asm-ppc/unistd.h | 5 ++++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff -urN linux-2.6.13-rc3-git8/arch/ppc/kernel/misc.S linux/arch/ppc/kernel/misc.S
> --- linux-2.6.13-rc3-git8/arch/ppc/kernel/misc.S 2005-07-27 10:59:31.000000000 -0400
> +++ linux/arch/ppc/kernel/misc.S 2005-07-27 11:25:43.000000000 -0400
> @@ -1451,3 +1451,6 @@
> .long sys_waitid
> .long sys_ioprio_set
> .long sys_ioprio_get
> + .long sys_inotify_init /* 275 */
> + .long sys_inotify_add_watch
> + .long sys_inotify_rm_watch
> diff -urN linux-2.6.13-rc3-git8/include/asm-ppc/unistd.h linux/include/asm-ppc/unistd.h
> --- linux-2.6.13-rc3-git8/include/asm-ppc/unistd.h 2005-07-27 10:59:32.000000000 -0400
> +++ linux/include/asm-ppc/unistd.h 2005-07-27 11:25:26.000000000 -0400
> @@ -279,8 +279,11 @@
> #define __NR_waitid 272
> #define __NR_ioprio_set 273
> #define __NR_ioprio_get 274
> +#define __NR_inotify_init 275
> +#define __NR_inotify_add_watch 276
> +#define __NR_inotify_rm_watch 277
>
> -#define __NR_syscalls 275
> +#define __NR_syscalls 278
>
> #define __NR(n) #n
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch] inotify: ppc64 syscalls.
2005-07-27 16:55 ` Andrew Morton
@ 2005-07-27 17:31 ` Robert Love
2005-07-27 20:27 ` David S. Miller
0 siblings, 1 reply; 6+ messages in thread
From: Robert Love @ 2005-07-27 17:31 UTC (permalink / raw)
To: Andrew Morton; +Cc: paulus, linux-kernel, ttb
On Wed, 2005-07-27 at 09:55 -0700, Andrew Morton wrote:
> ppc64 likes to keep its 32-bit-syscall table in sync with ppc32 so it'd be
> best to do ppc64 while we're at it (both sys_call_table and
> sys_call_table32)
Sure thing.
Attached find inotify system call support for PPC64.
[ I don't think we need sys32 compatibility versions--and if we do, I
failed in life. ]
Robert Love
Signed-off-by: Robert Love <rml@novell.com>
arch/ppc64/kernel/misc.S | 6 ++++++
include/asm-ppc64/unistd.h | 5 ++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff -urN linux-2.6.13-rc3-git8/arch/ppc64/kernel/misc.S linux/arch/ppc64/kernel/misc.S
--- linux-2.6.13-rc3-git8/arch/ppc64/kernel/misc.S 2005-07-27 10:59:31.000000000 -0400
+++ linux/arch/ppc64/kernel/misc.S 2005-07-27 13:26:36.000000000 -0400
@@ -1129,6 +1129,9 @@
.llong .compat_sys_waitid
.llong .sys32_ioprio_set
.llong .sys32_ioprio_get
+ .llong .sys_inotify_init /* 275 */
+ .llong .sys_inotify_add_watch
+ .llong .sys_inotify_rm_watch
.balign 8
_GLOBAL(sys_call_table)
@@ -1407,3 +1410,6 @@
.llong .sys_waitid
.llong .sys_ioprio_set
.llong .sys_ioprio_get
+ .llong .sys_inotify_init /* 275 */
+ .llong .sys_inotify_add_watch
+ .llong .sys_inotify_rm_watch
diff -urN linux-2.6.13-rc3-git8/include/asm-ppc64/unistd.h linux/include/asm-ppc64/unistd.h
--- linux-2.6.13-rc3-git8/include/asm-ppc64/unistd.h 2005-07-27 10:59:32.000000000 -0400
+++ linux/include/asm-ppc64/unistd.h 2005-07-27 13:27:24.000000000 -0400
@@ -285,8 +285,11 @@
#define __NR_waitid 272
#define __NR_ioprio_set 273
#define __NR_ioprio_get 274
+#define __NR_inotify_init 275
+#define __NR_inotify_add_watch 276
+#define __NR_inotify_rm_watch 277
-#define __NR_syscalls 275
+#define __NR_syscalls 278
#ifdef __KERNEL__
#define NR_syscalls __NR_syscalls
#endif
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] inotify: ppc64 syscalls.
2005-07-27 17:31 ` [patch] inotify: ppc64 syscalls Robert Love
@ 2005-07-27 20:27 ` David S. Miller
2005-07-27 20:31 ` Robert Love
0 siblings, 1 reply; 6+ messages in thread
From: David S. Miller @ 2005-07-27 20:27 UTC (permalink / raw)
To: rml; +Cc: akpm, paulus, linux-kernel, ttb
From: Robert Love <rml@novell.com>
Date: Wed, 27 Jul 2005 13:31:36 -0400
> [ I don't think we need sys32 compatibility versions--and if we do, I
> failed in life. ]
add_watch and rm_watch both do, because system call arguments are
zero-extended by default for compat tasks, thus the "fd" arg needs
sign extension.
You'll notice that sys_ppc32.c has a ton of shims which purely
exist to sign extend "int" system call arguments. Sparc64 does
something similarly, but in assembler so that we don't eat the
overhead of a full stack frame just to sign extend arguments.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] inotify: ppc64 syscalls.
2005-07-27 20:27 ` David S. Miller
@ 2005-07-27 20:31 ` Robert Love
2005-07-27 20:33 ` David S. Miller
0 siblings, 1 reply; 6+ messages in thread
From: Robert Love @ 2005-07-27 20:31 UTC (permalink / raw)
To: David S. Miller; +Cc: akpm, paulus, linux-kernel, ttb
On Wed, 2005-07-27 at 13:27 -0700, David S. Miller wrote:
> You'll notice that sys_ppc32.c has a ton of shims which purely
> exist to sign extend "int" system call arguments. Sparc64 does
> something similarly, but in assembler so that we don't eat the
> overhead of a full stack frame just to sign extend arguments.
Yah, but it looked like they did the sign extend thing for every int but
file descriptors, and fd's are the only int's we have.
Robert Love
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] inotify: ppc64 syscalls.
2005-07-27 20:31 ` Robert Love
@ 2005-07-27 20:33 ` David S. Miller
0 siblings, 0 replies; 6+ messages in thread
From: David S. Miller @ 2005-07-27 20:33 UTC (permalink / raw)
To: rml; +Cc: akpm, paulus, linux-kernel, ttb
From: Robert Love <rml@novell.com>
Date: Wed, 27 Jul 2005 16:31:02 -0400
> On Wed, 2005-07-27 at 13:27 -0700, David S. Miller wrote:
>
> > You'll notice that sys_ppc32.c has a ton of shims which purely
> > exist to sign extend "int" system call arguments. Sparc64 does
> > something similarly, but in assembler so that we don't eat the
> > overhead of a full stack frame just to sign extend arguments.
>
> Yah, but it looked like they did the sign extend thing for every int but
> file descriptors, and fd's are the only int's we have.
Ok, works for me :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-07-27 21:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-27 15:45 [patch] inotify: ppc32 syscalls Robert Love
2005-07-27 16:55 ` Andrew Morton
2005-07-27 17:31 ` [patch] inotify: ppc64 syscalls Robert Love
2005-07-27 20:27 ` David S. Miller
2005-07-27 20:31 ` Robert Love
2005-07-27 20:33 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox