From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
ebiederm@xmission.com
Subject: Re: Calling suspend() in halt/restart/shutdown -> not a good idea
Date: Wed, 03 Aug 2005 13:38:28 +0200 [thread overview]
Message-ID: <1123069109.30257.23.camel@gaston> (raw)
In-Reply-To: <20050802095312.GA1442@elf.ucw.cz>
On Tue, 2005-08-02 at 11:53 +0200, Pavel Machek wrote:
> Hi!
>
> > Why are we calling driver suspend routines in these ? This is _not_
>
> Well, reason is that if you remove device_suspend() you'll get
> emergency hard disk park during powerdown. As harddrives can survive
> only limited number of emergency stops, that is not a good idea.
No, that is bogus. We have shutdown() already for that and it used to be
implemented at least by IDE.
You are just blindly "dropping" the device_suspend() call in there
without thinking. There is a lot of differences between suspend and
shutdown, you can't "just do that". In addition to the number of drivers
with broken suspend of course, causing many boxes to not shutdown
anymore (and not only PPCs)
Andrew, please back that off before 2.6.13. I'll try to send a patch if
you want later today if I find some time with a kernel source at hand.
Ben.
next prev parent reply other threads:[~2005-08-03 11:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 15:09 Calling suspend() in halt/restart/shutdown -> not a good idea Benjamin Herrenschmidt
2005-08-01 18:37 ` Marc Ballarin
2005-08-01 20:08 ` Benjamin Herrenschmidt
2005-08-02 9:54 ` Pavel Machek
2005-08-03 11:40 ` Benjamin Herrenschmidt
2005-08-03 16:53 ` Kyle Moffett
2005-08-03 19:59 ` Benjamin Herrenschmidt
2005-08-04 20:56 ` Pavel Machek
2005-08-04 21:04 ` Pavel Machek
2005-08-02 9:53 ` Pavel Machek
2005-08-02 14:40 ` Eric W. Biederman
2005-08-02 14:45 ` Pavel Machek
2005-08-03 11:43 ` Benjamin Herrenschmidt
2005-08-03 11:43 ` Benjamin Herrenschmidt
2005-08-03 11:38 ` Benjamin Herrenschmidt [this message]
2005-08-04 2:27 ` Andrew Morton
2005-08-02 10:04 ` Pavel Machek
2005-08-03 11:41 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1123069109.30257.23.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox