From: Pavel Roskin <proski@gnu.org>
To: linux-kernel@vger.kernel.org, discuss@x86-64.org
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Subject: [PATCH 1/2] Re: Major breakage in linux-git on x86_64, oom killer goes on rampage
Date: Thu, 04 Aug 2005 17:01:36 -0400 [thread overview]
Message-ID: <1123189296.2332.7.camel@dv.roinet.com> (raw)
In-Reply-To: <1123185522.2462.14.camel@dv.roinet.com>
Hello again,
here's the solution. The x86_64 specific portion will be posted as a
separate patch.
> Now the system boot goes a little further and then the kernel reports a
> BUG in mm/memory.c:985. Apparently __handle_mm_fault() returns
> something unexpected.
I'm getting a BUG in mm/memory.c:985. The unexpected value is 18 or
VM_FAULT_MINOR|VM_FAULT_WRITE. As it turns out, __handle_mm_fault()
never returns VM_FAULT_WRITE, but in combination with VM_FAULT_MINOR.
Apparently, that's what was meant, and the fallthrough to case
VM_FAULT_MINOR is an indication of that.
Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/mm/memory.c b/mm/memory.c
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -963,7 +963,7 @@ int get_user_pages(struct task_struct *t
spin_unlock(&mm->page_table_lock);
switch (__handle_mm_fault(mm, vma, start,
write_access)) {
- case VM_FAULT_WRITE:
+ case VM_FAULT_WRITE|VM_FAULT_MINOR:
/*
* do_wp_page has broken COW when
* necessary, even if maybe_mkwrite
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2005-08-04 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-04 19:58 Major breakage in linux-git on x86_64, oom killer goes on rampage Pavel Roskin
2005-08-04 21:01 ` Pavel Roskin [this message]
2005-08-04 21:04 ` [PATCH 2/2] " Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1123189296.2332.7.camel@dv.roinet.com \
--to=proski@gnu.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox