public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <rml@novell.com>
To: marijn ros <marijn@mad.scientist.com>
Cc: John McCutchan <ttb@tentacle.dhs.org>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: [patch] fsnotify: hook on removexattr, too
Date: Fri, 05 Aug 2005 15:55:15 -0400	[thread overview]
Message-ID: <1123271715.30486.82.camel@betsy> (raw)
In-Reply-To: <20050805180739.A49DF1F50B1@ws1-2.us4.outblaze.com>


On Fri, 2005-08-05 at 19:07 +0100, marijn ros wrote:

> I got wondering, why does fs_notify_xattr get called from setxattr in fs/xattr.c, but
> not from removexattr that is below it in the same file? Both seem to make changes to
> xattrs and both are exported as system calls.

We should.

	Robert Love


Add fsnotify_xattr() hook to removexattr().

Signed-off-by: Robert Love <rml@novell.com>

 fs/xattr.c |    2 ++
 1 files changed, 2 insertions(+)

diff -urN linux-2.6.13-rc5/fs/xattr.c linux/fs/xattr.c
--- linux-2.6.13-rc5/fs/xattr.c	2005-08-05 15:49:17.000000000 -0400
+++ linux/fs/xattr.c	2005-08-05 15:53:45.000000000 -0400
@@ -307,6 +307,8 @@
 		down(&d->d_inode->i_sem);
 		error = d->d_inode->i_op->removexattr(d, kname);
 		up(&d->d_inode->i_sem);
+		if (!error)
+			fsnotify_xattr(d);
 	}
 out:
 	return error;



  reply	other threads:[~2005-08-05 19:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-05 18:07 fsnotify on removexattr marijn ros
2005-08-05 19:55 ` Robert Love [this message]
2005-08-05 20:05   ` [patch] fsnotify: hook on removexattr, too John McCutchan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1123271715.30486.82.camel@betsy \
    --to=rml@novell.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn@mad.scientist.com \
    --cc=ttb@tentacle.dhs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox