* fsnotify on removexattr
@ 2005-08-05 18:07 marijn ros
2005-08-05 19:55 ` [patch] fsnotify: hook on removexattr, too Robert Love
0 siblings, 1 reply; 3+ messages in thread
From: marijn ros @ 2005-08-05 18:07 UTC (permalink / raw)
To: linux-kernel
I got wondering, why does fs_notify_xattr get called from setxattr in fs/xattr.c, but not from removexattr that is below it in the same file? Both seem to make changes to xattrs and both are exported as system calls.
Bye,
Marijn
--
___________________________________________________________
Sign-up for Ads Free at Mail.com
http://promo.mail.com/adsfreejump.htm
^ permalink raw reply [flat|nested] 3+ messages in thread
* [patch] fsnotify: hook on removexattr, too
2005-08-05 18:07 fsnotify on removexattr marijn ros
@ 2005-08-05 19:55 ` Robert Love
2005-08-05 20:05 ` John McCutchan
0 siblings, 1 reply; 3+ messages in thread
From: Robert Love @ 2005-08-05 19:55 UTC (permalink / raw)
To: marijn ros; +Cc: John McCutchan, Andrew Morton, linux-kernel
On Fri, 2005-08-05 at 19:07 +0100, marijn ros wrote:
> I got wondering, why does fs_notify_xattr get called from setxattr in fs/xattr.c, but
> not from removexattr that is below it in the same file? Both seem to make changes to
> xattrs and both are exported as system calls.
We should.
Robert Love
Add fsnotify_xattr() hook to removexattr().
Signed-off-by: Robert Love <rml@novell.com>
fs/xattr.c | 2 ++
1 files changed, 2 insertions(+)
diff -urN linux-2.6.13-rc5/fs/xattr.c linux/fs/xattr.c
--- linux-2.6.13-rc5/fs/xattr.c 2005-08-05 15:49:17.000000000 -0400
+++ linux/fs/xattr.c 2005-08-05 15:53:45.000000000 -0400
@@ -307,6 +307,8 @@
down(&d->d_inode->i_sem);
error = d->d_inode->i_op->removexattr(d, kname);
up(&d->d_inode->i_sem);
+ if (!error)
+ fsnotify_xattr(d);
}
out:
return error;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] fsnotify: hook on removexattr, too
2005-08-05 19:55 ` [patch] fsnotify: hook on removexattr, too Robert Love
@ 2005-08-05 20:05 ` John McCutchan
0 siblings, 0 replies; 3+ messages in thread
From: John McCutchan @ 2005-08-05 20:05 UTC (permalink / raw)
To: Robert Love; +Cc: marijn ros, Andrew Morton, linux-kernel
On Fri, 2005-08-05 at 15:55 -0400, Robert Love wrote:
> On Fri, 2005-08-05 at 19:07 +0100, marijn ros wrote:
>
> > I got wondering, why does fs_notify_xattr get called from setxattr in fs/xattr.c, but
> > not from removexattr that is below it in the same file? Both seem to make changes to
> > xattrs and both are exported as system calls.
>
> We should.
>
Yes we should.
Signed-off-by: John McCtuchan <ttb@tentacle.dhs.org>
--
John McCutchan <ttb@tentacle.dhs.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-08-05 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-05 18:07 fsnotify on removexattr marijn ros
2005-08-05 19:55 ` [patch] fsnotify: hook on removexattr, too Robert Love
2005-08-05 20:05 ` John McCutchan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox