public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stelian Pop <stelian@popies.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Olof Johansson <olof@lixom.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Export handle_mm_fault to modules.
Date: Sat, 06 Aug 2005 23:07:14 +0200	[thread overview]
Message-ID: <1123362434.4635.2.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.58.0508051642360.3258@g5.osdl.org>

Le vendredi 05 août 2005 à 16:43 -0700, Linus Torvalds a écrit :
> 
> On Fri, 5 Aug 2005, Olof Johansson wrote:
> >
> > On Fri, Aug 05, 2005 at 04:02:13PM -0700, Linus Torvalds wrote:
> > 
> > > The only thing that has ever exported it afaik is
> > > 
> > > 	arch/ppc/kernel/ppc_ksyms.c:EXPORT_SYMBOL(handle_mm_fault); /* For MOL */
> > > 
> > > and that looks pretty suspicious too (what is MOL, and regardless, 
> > > shouldn't it be an EXPORT_SYMBOL_GPL?).
> > 
> > Mac-on-Linux, see http://www.maconlinux.org/. Run MacOS in a virtualized
> > machine under Linux (or the other way around). It's GPL.
> 
> Ok. Then I suspect the right patch is this one. Stelian, can you verify?

I confirm, it works perfectly.

Stelian.

> 
> 		Linus
> ---
> diff --git a/arch/ppc/kernel/ppc_ksyms.c b/arch/ppc/kernel/ppc_ksyms.c
> --- a/arch/ppc/kernel/ppc_ksyms.c
> +++ b/arch/ppc/kernel/ppc_ksyms.c
> @@ -324,7 +324,7 @@ EXPORT_SYMBOL(__res);
>  
>  EXPORT_SYMBOL(next_mmu_context);
>  EXPORT_SYMBOL(set_context);
> -EXPORT_SYMBOL(handle_mm_fault); /* For MOL */
> +EXPORT_SYMBOL_GPL(__handle_mm_fault); /* For MOL */
>  EXPORT_SYMBOL(disarm_decr);
>  #ifdef CONFIG_PPC_STD_MMU
>  extern long mol_trampoline;
> 
-- 
Stelian Pop <stelian@popies.net>


  reply	other threads:[~2005-08-06 21:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-05 21:55 [PATCH] Export handle_mm_fault to modules Stelian Pop
2005-08-05 22:22 ` Dave Jones
2005-08-05 23:02 ` Linus Torvalds
2005-08-05 23:25   ` Olof Johansson
2005-08-05 23:43     ` Linus Torvalds
2005-08-06 21:07       ` Stelian Pop [this message]
2005-08-08  8:44       ` Arnd Bergmann
2005-08-08 18:42         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1123362434.4635.2.camel@localhost.localdomain \
    --to=stelian@popies.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox