public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@cyclades.com>
To: Patrick Mochel <mochel@digitalimplant.org>,
	Christoph Lameter <christoph@lameter.com>
Cc: Linux-pm mailing list <linux-pm@lists.osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [linux-pm] [PATCH] Workqueue freezer support.
Date: Mon, 08 Aug 2005 22:18:57 +1000	[thread overview]
Message-ID: <1123503537.3969.525.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.50.0508052148280.19501-100000@monsoon.he.net>

Ok. Now that I've actually done some work toward getting it to work with
Suspend2, I'll give a more cogent response to Christoph's approach.

I believe it can work, but the algorithm in freeze() is a bit of a
concern.

Checking whether the todo list is empty is fine while we're the only
user, but when other functionality is using this, it will be unreliable.
We'll either need a quick way to check what todo work is pending for a
task (traverse list would be racy). We can't say "We know we signalled
them all already" because more might have forked.

One possibility might be to leverage the existing counting - when
num_signalled = num_frozen, we can signal a new batch with impunity. But
this assumes everything signalled properly enters the fridge (which
might not always be guaranteed).

Perhaps it's best to keep PF_FREEZING? Perhaps there's another
possibility.

Regards,

Nigel
-- 
Evolution.
Enumerate the requirements.
Consider the interdependencies.
Calculate the probabilities.


      parent reply	other threads:[~2005-08-08 21:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-21  5:17 [PATCH] Workqueue freezer support Nigel Cunningham
2005-07-21 15:38 ` [linux-pm] " Pavel Machek
2005-07-21 15:42   ` Ingo Molnar
2005-07-21 15:44     ` Pavel Machek
2005-07-21 19:42 ` Patrick Mochel
2005-07-22  3:02   ` Nigel Cunningham
2005-08-05 12:12   ` Nigel Cunningham
2005-08-06  5:06     ` Patrick Mochel
2005-08-08  0:46       ` Nigel Cunningham
2005-08-08  1:27         ` Con Kolivas
2005-08-08  1:38           ` Nigel Cunningham
2005-08-08 12:18       ` Nigel Cunningham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1123503537.3969.525.camel@localhost \
    --to=ncunningham@cyclades.com \
    --cc=christoph@lameter.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=mochel@digitalimplant.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox