From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1750902AbVHHOcT@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750902AbVHHOcT (ORCPT <rfc822;willy@w.ods.org>);
	Mon, 8 Aug 2005 10:32:19 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750906AbVHHOcT
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 8 Aug 2005 10:32:19 -0400
Received: from smtp2.brturbo.com.br ([200.199.201.158]:55732 "EHLO
	smtp2.brturbo.com.br") by vger.kernel.org with ESMTP
	id S1750902AbVHHOcS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Aug 2005 10:32:18 -0400
Subject: Re: [PATCH] DVB: lgdt330x frontend: some bug fixes & add lgdt3303
	support
From: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
To: mkrufky@m1k.net
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>,
       linux-dvb-maintainer@linuxtv.org,
       Mac Michaels <wmichaels1@earthlink.net>
In-Reply-To: <42F7634B.2000504@m1k.net>
References: <42F6A294.90300@linuxtv.org>
	 <1123504387.17427.9.camel@localhost>  <42F7634B.2000504@m1k.net>
Content-Type: text/plain; charset=ISO-8859-1
Date: Mon, 08 Aug 2005 11:32:07 -0300
Message-Id: <1123511527.4879.39.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.3-5mdk 
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Em Seg, 2005-08-08 ās 09:51 -0400, Michael Krufky escreveu:
> Mauro Carvalho Chehab wrote:
> 
> >	This should't be applied to 2.6.13. It does contain a hack at V4L code,
> >since mute_tda9887 is implemented outside tda9887.c module and could
> >potentially cause troubles since there are some work to provide it on a
> >correct way.
> >  
> >
> This patch removes the tda9887 stuff from lgdt330x.c.
Perfect.
> 
> Signed-off-by: Michael Krufky <mkrufky@m1k.net>

Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>

>  linux/drivers/media/dvb/frontends/lgdt330x.c |   35 -------------------
>  1 files changed, 35 deletions(-)
> 
> diff -u linux-2.6.13/drivers/media/dvb/frontends/lgdt330x.c linux/drivers/media/dvb/frontends/lgdt330x.c
> --- linux-2.6.13/drivers/media/dvb/frontends/lgdt330x.c	2005-08-08 09:46:25.000000000 +0000
> +++ linux/drivers/media/dvb/frontends/lgdt330x.c	2005-08-08 09:48:24.000000000 +0000
> @@ -172,38 +172,6 @@
>  	}
>  }
>  
> -#ifdef MUTE_TDA9887
> -static int i2c_write_ntsc_demod (struct lgdt330x_state* state, u8 buf[2])
> -{
> -	struct i2c_msg msg =
> -		{ .addr = 0x43,
> -		  .flags = 0, 
> -		  .buf = buf,
> -		  .len = 2 };
> -	int err;
> -
> -	if ((err = i2c_transfer(state->i2c, &msg, 1)) != 1) {
> -			printk(KERN_WARNING "lgdt330x: %s error (addr %02x <- %02x, err = %i)\n", __FUNCTION__, msg.buf[0], msg.buf[1], err);
> -		if (err < 0)
> -			return err;
> -		else
> -			return -EREMOTEIO;
> -	}
> -	return 0;
> -}
> -
> -static void fiddle_with_ntsc_if_demod(struct lgdt330x_state* state)
> -{
> -	// Experimental code
> -	u8 buf0[] = {0x00, 0x20};
> -	u8 buf1[] = {0x01, 0x00};
> -	u8 buf2[] = {0x02, 0x00};
> -
> -	i2c_write_ntsc_demod(state, buf0);
> -	i2c_write_ntsc_demod(state, buf1);
> -	i2c_write_ntsc_demod(state, buf2);
> -}
> -#endif
>  
>  static int lgdt330x_init(struct dvb_frontend* fe)
>  {
> @@ -267,9 +235,6 @@
>  		chip_name = "LGDT3303";
>  		err = i2c_write_demod_bytes(state, lgdt3303_init_data, 
>  									sizeof(lgdt3303_init_data));
> -#ifdef MUTE_TDA9887
> -		fiddle_with_ntsc_if_demod(state);
> -#endif
>    		break;
>  	default:
>  		chip_name = "undefined";
Cheers,
Mauro.