public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@rpsys.net>
To: Christoph Lameter <christoph@lameter.com>
Cc: Andrew Morton <akpm@osdl.org>,
	nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org
Subject: Re: 2.6.13-rc3-mm3
Date: Mon, 08 Aug 2005 23:12:31 +0100	[thread overview]
Message-ID: <1123539152.7716.25.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.62.0508080945100.19665@graphe.net>

I've done a bit of analysis:

cmpxchg fail fault mm=c3945b20 vma=c304ad84 addr=402cb000 write=2048
ptep=c2af5b2c pmd=c2bc5008 entry=886c0f7 new=886c077 current=886c077

Note the Dirty bit is set on entry and not new where it probably should
be...

  ptep_cmpxchg(mm, address, pte, entry, new_entry)

This will compare "current"(886c077) with "entry"(886c0f7) which are not
equal and the whole thing therefore correctly fails leading to the loop.

The following patch (against -mm) cleared the problem up but I'm not
sure how correct it is:

Index: linux-2.6.12/mm/memory.c
===================================================================
--- linux-2.6.12.orig/mm/memory.c	2005-08-08 23:03:45.000000000 +0100
+++ linux-2.6.12/mm/memory.c	2005-08-08 23:04:02.000000000 +0100
@@ -2046,7 +2046,7 @@
 			return do_wp_page(mm, vma, address, pte, pmd, entry);
 #endif
 		}
-		entry = pte_mkdirty(entry);
+		new_entry = pte_mkdirty(entry);
 	}
 
 	/*



  parent reply	other threads:[~2005-08-08 22:12 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-28  9:58 2.6.13-rc3-mm3 Andrew Morton
2005-07-28 10:44 ` [-mm patch] fix MTRR compilation with SMP=n Adrian Bunk
2005-07-28 17:11 ` 2.6.13-rc3-mm3 Christoph Lameter
2005-07-28 19:52   ` 2.6.13-rc3-mm3 Russell King
2005-07-28 20:06     ` 2.6.13-rc3-mm3 Christoph Lameter
2005-07-28 19:11 ` 2.6.13-rc3-mm3 Rafael J. Wysocki
2005-07-28 19:16   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-28 21:40     ` 2.6.13-rc3-mm3 Rafael J. Wysocki
2005-07-28 23:31       ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-29  7:06       ` 2.6.13-rc3-mm3 Matthias Urlichs
2005-07-29  9:27         ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-29 12:01           ` 2.6.13-rc3-mm3 Matthias Urlichs
2005-07-29 14:12           ` Regression hunting with git (was: Re: 2.6.13-rc3-mm3) Matthias Urlichs
2005-07-28 20:34 ` 2.6.13-rc3-mm3 Adrian Bunk
2005-07-28 22:09 ` 2.6.13-rc3-mm3 Michael Thonke
2005-07-28 20:15   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-28 20:56     ` 2.6.13-rc3-mm3 Nick Sillik
2005-07-28 23:16       ` 2.6.13-rc3-mm3 Michael Thonke
2005-07-28 20:29   ` 2.6.13-rc3-mm3 Adrian Bunk
2005-07-28 23:29 ` 2.6.13-rc3-mm3 Michael Thonke
2005-07-28 22:02   ` 2.6.13-rc3-mm3 Dirk
2005-07-28 23:46   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-29 15:48     ` 2.6.13-rc3-mm3 Michael Thonke
2005-07-29 19:33       ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-30  0:00         ` 2.6.13-rc3-mm3 Michael Thonke
2005-07-29  5:58 ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-07-29  6:08   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-29 15:21     ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-07-29 16:15       ` 2.6.13-rc3-mm3 Eric W. Biederman
2005-07-29  6:01 ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-07-29  6:10   ` 2.6.13-rc3-mm3 Andrew Morton
2005-08-03  1:17     ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-08-03  4:21       ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-08-07 23:23         ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-07-29  6:02 ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-07-29 23:05 ` 2.6.13-rc3-mm3 Khalid Aziz
2005-07-29 23:17   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-30 15:33     ` 2.6.13-rc3-mm3 Khalid Aziz
2005-07-30 18:02       ` 2.6.13-rc3-mm3 Andrew Morton
2005-08-01 15:36     ` 2.6.13-rc3-mm3 Bjorn Helgaas
2005-07-30 10:27 ` 2.6.13-rc3-mm3 Richard Purdie
2005-07-30 17:05   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-31  9:04 ` 2.6.13-rc3-mm3 Manuel Lauss
2005-07-31  9:16   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-31 11:12     ` 2.6.13-rc3-mm3 Manuel Lauss
2005-07-31 12:46     ` 2.6.13-rc3-mm3 Manuel Lauss
2005-07-31 17:35       ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-31 18:21         ` 2.6.13-rc3-mm3 Manuel Lauss
2005-07-31 18:25   ` 2.6.13-rc3-mm3 Linus Torvalds
2005-07-31 18:41     ` 2.6.13-rc3-mm3 Manuel Lauss
2005-07-31 18:59       ` 2.6.13-rc3-mm3 Linus Torvalds
2005-07-31 21:35     ` 2.6.13-rc3-mm3 Stelian Pop
     [not found]     ` <Pine.LNX.4.58.0507311125360.29650@g5.osdl.org>
     [not found]       ` <1122846072.17880.43.camel@deep-space-9.dsnet>
     [not found]         ` <Pine.LNX.4.58.0507311557020.14342@g5.osdl.org>
2005-08-01 14:37           ` 2.6.13-rc3-mm3 Stelian Pop
2005-08-02  9:49             ` 2.6.13-rc3-mm3 Stelian Pop
2005-08-02 10:32               ` 2.6.13-rc3-mm3 Manuel Lauss
2005-08-02 11:40                 ` 2.6.13-rc3-mm3 Ivan Kokshaysky
2005-08-02 14:04                   ` 2.6.13-rc3-mm3 Manuel Lauss
2005-08-02 15:48                   ` 2.6.13-rc3-mm3 Linus Torvalds
2005-08-02 16:50                     ` 2.6.13-rc3-mm3 Ivan Kokshaysky
2005-08-02 17:11                       ` 2.6.13-rc3-mm3 Linus Torvalds
2005-08-02 21:13                         ` 2.6.13-rc3-mm3 Ivan Kokshaysky
2005-08-02 21:21                           ` 2.6.13-rc3-mm3 Greg KH
2005-08-02 21:47                             ` 2.6.13-rc3-mm3 Ivan Kokshaysky
2005-08-02 21:57                               ` 2.6.13-rc3-mm3 Linus Torvalds
2005-08-02 22:59                                 ` [patch 1/2] increase PCIBIOS_MIN_IO on x86 Ivan Kokshaysky
2005-08-02 23:09                                 ` [patch 2/2] ACPI: " Ivan Kokshaysky
2005-08-01  1:43 ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 16:10   ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 20:02     ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 20:36       ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 21:07         ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 21:16           ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 21:27             ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 21:40               ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 21:52                 ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 22:02                   ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 22:19                   ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 23:01                     ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 23:16                       ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 23:32                         ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-04  0:19                       ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-04 11:27                         ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-04 14:04                           ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-04 14:37                             ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-05 15:17                               ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-07 13:44                                 ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-08 16:48                                   ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-08 17:10                                     ` 2.6.13-rc3-mm3 Russell King
2005-08-08 17:15                                       ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-08 20:40                                     ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-08 22:12                                     ` Richard Purdie [this message]
2005-08-09  0:57                                       ` 2.6.13-rc3-mm3 Christoph Lameter
2005-09-14 14:32 ` 2.6.13-mm3 and 2.6.14-rc1 both broken (SCSI?) Martin J. Bligh
2005-09-14 14:09   ` Anton Blanchard
  -- strict thread matches above, loose matches on Subject: below --
2005-07-28 10:40 2.6.13-rc3-mm3 Sebastian Kaergel
2005-07-28  9:54 ` 2.6.13-rc3-mm3 Alexandre Buisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1123539152.7716.25.camel@localhost.localdomain \
    --to=rpurdie@rpsys.net \
    --cc=akpm@osdl.org \
    --cc=christoph@lameter.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox