From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965127AbVHJOTX (ORCPT ); Wed, 10 Aug 2005 10:19:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965125AbVHJOTX (ORCPT ); Wed, 10 Aug 2005 10:19:23 -0400 Received: from stat16.steeleye.com ([209.192.50.48]:41877 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S965112AbVHJOTX (ORCPT ); Wed, 10 Aug 2005 10:19:23 -0400 Subject: [PATCH] remove name length check in a workqueue From: James Bottomley To: Andrew Morton , mingo@redhat.com Cc: Linux Kernel , SCSI Mailing List Content-Type: text/plain Date: Wed, 10 Aug 2005 09:19:04 -0500 Message-Id: <1123683544.5093.4.camel@mulgrave> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Ingo, This has been in the workqueue code in day one, for no real reason that I can see. We just tripped over it in SCSI because the fibre channel transport class creates one workqueue per host with the name scsi_wq_%d which trips this after we get to 100. Unfortunately we just came across someone with > 100 host adapters ... I think the solution is just to get rid of the artificial limit. James diff --git a/kernel/workqueue.c b/kernel/workqueue.c --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -308,8 +308,6 @@ struct workqueue_struct *__create_workqu struct workqueue_struct *wq; struct task_struct *p; - BUG_ON(strlen(name) > 10); - wq = kmalloc(sizeof(*wq), GFP_KERNEL); if (!wq) return NULL;