From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Torvalds <torvalds@osdl.org>,
kiran@scalex86.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix ide-disk.c oops caused by hwif == NULL
Date: Wed, 10 Aug 2005 15:59:57 +0100 [thread overview]
Message-ID: <1123685998.28913.3.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.62.0508100604020.12126@schroedinger.engr.sgi.com>
On Mer, 2005-08-10 at 06:07 -0700, Christoph Lameter wrote:
> Correct. So we need to indeed go back to a version that does check for
> NULL that I initially proposed.
No, you need to fix the caller. "hwif_to_node(NULL)" is a nonsense
operation rather like strlen(NULL). The caller need to be fixed.
next prev parent reply other threads:[~2005-08-10 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200508100459.j7A4xTn7016128@hera.kernel.org>
2005-08-10 11:11 ` [PATCH] Fix ide-disk.c oops caused by hwif == NULL Geert Uytterhoeven
2005-08-10 13:07 ` Christoph Lameter
2005-08-10 13:13 ` Bartlomiej Zolnierkiewicz
2005-08-10 13:28 ` Christoph Lameter
2005-08-10 14:59 ` Alan Cox [this message]
2005-08-11 2:18 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1123685998.28913.3.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=clameter@engr.sgi.com \
--cc=geert@linux-m68k.org \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox