From: Dave Kleikamp <shaggy@austin.ibm.com>
To: Con Kolivas <kernel@kolivas.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.13-rc4-mm1: Divide by zero in find_idlest_group
Date: Thu, 11 Aug 2005 11:09:19 -0500 [thread overview]
Message-ID: <1123776559.32056.1.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <200508120127.39436.kernel@kolivas.org>
On Fri, 2005-08-12 at 01:27 +1000, Con Kolivas wrote:
> On Fri, 12 Aug 2005 01:21 am, Dave Kleikamp wrote:
> > Should there be any locking around this? Or should the value of
> > rq->nr_running be saved to a local variable as in this untested patch?
>
> Very sneaky..
>
> On initial inspection your patch makes complete sense. I see no point in
> adding locking to this function as the accuracy is not critical. Want to give
> your patch a run and then push it to akpm? Thanks!
Okay, I'm testing it now. It took running overnight to hit the problem
before, so I'll let it run until tomorrow before I push it.
> Cheers,
> Con
--
David Kleikamp
IBM Linux Technology Center
prev parent reply other threads:[~2005-08-11 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 15:21 2.6.13-rc4-mm1: Divide by zero in find_idlest_group Dave Kleikamp
2005-08-11 15:27 ` Con Kolivas
2005-08-11 16:09 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1123776559.32056.1.camel@kleikamp.austin.ibm.com \
--to=shaggy@austin.ibm.com \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox