From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Pekka J Enberg <penberg@cs.Helsinki.FI>
Cc: Arjan van de Ven <arjan@infradead.org>,
Denis Vlasenko <vda@ilport.com.ua>, Adrian Bunk <bunk@stusta.de>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] make kcalloc() a static inline
Date: Mon, 15 Aug 2005 14:51:13 +0100 [thread overview]
Message-ID: <1124113874.4437.21.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.58.0508151601540.3068@sbz-30.cs.Helsinki.FI>
On Llu, 2005-08-15 at 16:06 +0300, Pekka J Enberg wrote:
> and I saw small reduction in kernel text with kcalloc() inlined. If GCC
> is, in fact, spreading the extra operations everywhere, shouldn't kernel
> text be bigger?
Only if the cost of the function call in lines of code is higher than
the inline code. That includes the less obvious cost for the fact that
its a synchronization point so you can't do certain optimisations
through a function call (the function you are calling may read/write any
global/static variable or pointer target).
Alan
next prev parent reply other threads:[~2005-08-15 13:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-08 22:38 [-mm patch] make kcalloc() a static inline Adrian Bunk
2005-08-09 5:09 ` Pekka J Enberg
2005-08-15 8:06 ` [-mm patch] " Denis Vlasenko
2005-08-15 8:14 ` Arjan van de Ven
2005-08-15 8:20 ` Denis Vlasenko
2005-08-15 8:28 ` Pekka J Enberg
2005-08-15 9:33 ` Denis Vlasenko
2005-08-15 9:41 ` Arjan van de Ven
2005-08-15 12:17 ` Denis Vlasenko
2005-08-15 12:25 ` Arjan van de Ven
2005-08-15 13:06 ` Pekka J Enberg
2005-08-15 13:51 ` Alan Cox [this message]
2005-08-15 16:30 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1124113874.4437.21.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.Helsinki.FI \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox