From: John McCutchan <ttb@tentacle.dhs.org>
To: Robert Love <rml@novell.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, jim.houston@ccur.com
Subject: Re: [patch] inotify: idr_get_new_above not working?
Date: Mon, 15 Aug 2005 12:35:12 -0400 [thread overview]
Message-ID: <1124123712.6343.0.camel@vertex> (raw)
In-Reply-To: <1124123274.23297.122.camel@betsy>
On Mon, 2005-08-15 at 12:27 -0400, Robert Love wrote:
> On Mon, 2005-08-15 at 10:16 -0400, John McCutchan wrote:
>
> > Inotify is using idr_get_new_above to make sure that the next watch
> > descriptor is larger/different than any of the previous watch
> > descriptors. We keep track of the largest wd that we get out of
> > idr_get_new_above, and pass that to idr_get_new_above. I have noticed
> > though, that idr_get_new_above always returns the first available id.
> > This causes a serious problem for inotify, because user space will get a
> > IGNORE event for a wd K that might refer to the last holder of the K.
>
> Turns out that the problem was in our court and not the idr layer.
> idr_get_new_above() seems to work fine.
>
> One-line patch is attached. Please merge before 2.6.13.
My bad! Patch looks correct.
Signed-off-by: John McCutchan <ttb@tentacle.dhs.org>
--
John McCutchan <ttb@tentacle.dhs.org>
prev parent reply other threads:[~2005-08-15 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-15 14:16 idr_get_new_above not working? John McCutchan
2005-08-15 16:27 ` [patch] inotify: " Robert Love
2005-08-15 16:35 ` John McCutchan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1124123712.6343.0.camel@vertex \
--to=ttb@tentacle.dhs.org \
--cc=akpm@osdl.org \
--cc=jim.houston@ccur.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@novell.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox