From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: ptb@inv.it.uc3m.es
Cc: linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: sleep under spinlock, sequencer.c, 2.6.12.5
Date: Fri, 19 Aug 2005 19:07:09 +0100 [thread overview]
Message-ID: <1124474829.32050.6.camel@localhost.localdomain> (raw)
In-Reply-To: <200508190813.j7J8Dml28378@inv.it.uc3m.es>
On Gwe, 2005-08-19 at 10:13 +0200, Peter T. Breuer wrote:
> The following "sleep under spinlock" is still present as of linux
> 2.6.12.5 in sound/oss/sequencer.c in midi_outc:
>
>
> n = 3 * HZ; /* Timeout */
>
> spin_lock_irqsave(&lock,flags);
> while (n && !midi_devs[dev]->outputc(dev, data)) {
> interruptible_sleep_on_timeout(&seq_sleeper, HZ/25);
> n--;
> }
> spin_unlock_irqrestore(&lock,flags);
>
>
> I haven't thought about it, just noted it. It's been there forever
> (some others in the sound architecture have been gradually disappearing
> as newer kernels come out).
Yep thats a blind substition of lock_kernel in an old tree it seems.
Probably my fault. Should drop it before the sleep and take it straight
after.
next prev parent reply other threads:[~2005-08-19 23:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-19 8:13 sleep under spinlock, sequencer.c, 2.6.12.5 Peter T. Breuer
2005-08-19 18:07 ` Alan Cox [this message]
2005-08-20 0:01 ` Nish Aravamudan
2005-08-22 15:17 ` Peter T. Breuer
2005-08-22 16:22 ` Nish Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1124474829.32050.6.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=ptb@inv.it.uc3m.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox