From: Shaohua Li <shaohua.li@intel.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add MCE resume under ia32
Date: Wed, 24 Aug 2005 11:47:58 +0800 [thread overview]
Message-ID: <1124855278.5047.2.camel@linux-hp.sh.intel.com> (raw)
In-Reply-To: <200508240512.35827.ak@suse.de>
On Wed, 2005-08-24 at 05:12 +0200, Andi Kleen wrote:
> On Wednesday 24 August 2005 03:59, Shaohua Li wrote:
> > On Wed, 2005-08-24 at 03:52 +0200, Andi Kleen wrote:
> > > Shaohua Li <shaohua.li@intel.com> writes:
> > > > x86-64 has resume support. It uses 'on_each_cpu' in resume method,
> > > > which is known broken. We'd better fix it.
> > >
> > > What is broken with it?
> >
> > It's a sysdev. The resume method is invoked with interrupt disabled.
>
> But only local interrupt disabled, no?
>
> Hmm - didn't we have a WARN_ON(irqs_disabled()) in smp_call_function().
>
> Anyways, it'll probably still work for now because the system should
> be synchronized at this point.
We are using cpu hotplug framework for MP suspend/resume. When sysdev's
resume is calling, APs actually aren't up. So it actually can't work.
Thanks,
Shaohua
next prev parent reply other threads:[~2005-08-24 3:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1124762500.3013.3.camel@linux-hp.sh.intel.com.suse.lists.linux.kernel>
[not found] ` <20050823103256.GB2795@elf.ucw.cz.suse.lists.linux.kernel>
[not found] ` <1124846001.3007.7.camel@linux-hp.sh.intel.com.suse.lists.linux.kernel>
2005-08-24 1:52 ` [PATCH] Add MCE resume under ia32 Andi Kleen
2005-08-24 1:59 ` Shaohua Li
2005-08-24 3:12 ` Andi Kleen
2005-08-24 3:47 ` Shaohua Li [this message]
2005-08-24 3:59 ` Andi Kleen
2005-08-24 4:16 ` Shaohua Li
2005-08-24 4:26 ` Andi Kleen
2005-08-24 4:31 ` Shaohua Li
2005-08-24 13:43 ` Pavel Machek
2005-08-23 2:01 Shaohua Li
2005-08-23 10:32 ` Pavel Machek
2005-08-24 1:13 ` Shaohua Li
2005-08-24 8:50 ` Pavel Machek
2005-08-25 2:36 ` Shaohua Li
2005-08-25 9:08 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1124855278.5047.2.camel@linux-hp.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox