public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Revell <rlrevell@joe-job.com>
To: Denis Vlasenko <vda@ilport.com.ua>
Cc: Udo van den Heuvel <udovdh@xs4all.nl>, linux-kernel@vger.kernel.org
Subject: Re: VIA Rhine ethernet driver bug (reprise...)
Date: Wed, 24 Aug 2005 11:50:23 -0400	[thread overview]
Message-ID: <1124898624.3855.3.camel@mindpipe> (raw)
In-Reply-To: <200508231221.59299.vda@ilport.com.ua>

On Tue, 2005-08-23 at 12:21 +0300, Denis Vlasenko wrote:
> My suggestion was, and still is:
> 
> >Since it happens less than once a day, why not just add a code
> >to reset the NIC completely in this case, like it is
> >typically done in tx_timeout handlers of many NICs, and forget about
> it?
> 
> Do you see any problems in this approach? 

Yes, hacks like that often causes a long non-preemptible section because
code that was only intended to run on boot now gets hung off a timer and
can run in the middle of real work.

I have an EPIA 6000 with a via Rhine and I've never seen this bug, so it
must be something specific to your network.  Better to find the bug and
fix it rather than add stupid hacks.

Lee


  reply	other threads:[~2005-08-24 15:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-22 17:29 VIA Rhine ethernet driver bug (reprise...) Udo van den Heuvel
2005-08-23  9:21 ` Denis Vlasenko
2005-08-24 15:50   ` Lee Revell [this message]
2005-08-24 16:03     ` Lee Revell
     [not found]   ` <6981e08b0508252043139cfa2d@mail.gmail.com>
2005-08-26  6:33     ` Denis Vlasenko
2005-08-26  7:49       ` Jeff Garzik
2005-08-26  9:04         ` Roger Luethi
2005-10-04 15:19           ` Jeff Garzik
2005-08-26 10:04         ` Denis Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1124898624.3855.3.camel@mindpipe \
    --to=rlrevell@joe-job.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=udovdh@xs4all.nl \
    --cc=vda@ilport.com.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox