From: Stephen Boyd <sboyd@kernel.org>
To: Mohammad Rafi Shaik <quic_mohs@quicinc.com>,
agross@kernel.org, andersson@kernel.org, broonie@kernel.org,
konrad.dybcio@somainline.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, mturquette@baylibre.com,
quic_plai@quicinc.com, quic_rohkumar@quicinc.com,
quic_visr@quicinc.com, robh+dt@kernel.org, swboyd@chromium.org
Subject: Re: [PATCH v1 4/4] clk: qcom: lpasscc-sc7280: Remove qdsp6ss clock registration
Date: Wed, 29 Mar 2023 10:57:34 -0700 [thread overview]
Message-ID: <1125013051e5f6578fde8aa006c9bcbd.sboyd@kernel.org> (raw)
In-Reply-To: <41d84c24-a363-7f73-1590-c23cc2ecbdc5@quicinc.com>
Quoting Mohammad Rafi Shaik (2023-03-29 02:24:43)
>
> The main issue with sc7280.dtsi file.
>
> Required to upstream remoteproc_adsp node for audioreach adsp based
> solution.
> The base address for remoteproc_adsp dts node is 0x3000000.
>
> Please refer below link audioreach dts patch:
> https://patchwork.kernel.org/project/linux-arm-msm/patch/1675700201-12890-4-git-send-email-quic_srivasam@quicinc.com/
>
> remoteproc_adsp: remoteproc@3000000 {
> compatible = "qcom,sc7280-adsp-pil";
> reg = <0 0x03000000 0 0x5000>, <0 0x0355b000 0 0x10>;
> reg-names = "qdsp6ss_base", "lpass_efuse";
>
> and in sc7280.dtsi lpasscc node base address also same.
>
> lpasscc: lpasscc@3000000 {
> compatible = "qcom,sc7280-lpasscc";
> reg = <0 0x03000000 0 0x40>,
> <0 0x03c04000 0 0x4>,
>
> In single dtsi file should not have same physical address node.
> Required to sort the nodes based on physical address.
Yes the same address shouldn't be used twice, but it still compiles,
right? The node name is different, remoteproc vs. clock-controller, so
it should work for the interim while the qcom,sc7280-lpasscc-2 binding
is written that only has one reg property.
I'm suggesting you don't change the existing binding. Instead, deprecate
the compatible and add a new compatible for the binding that omits the
second reg property. Then the driver patch can work with old and new dts
files.
next prev parent reply other threads:[~2023-03-29 17:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 16:32 [PATCH v1 0/4] Remove the qdsp6ss register from lpasscc Mohammad Rafi Shaik
2023-03-27 16:32 ` [PATCH v1 1/4] arm64: dts: qcom: sc7280: Modify lpasscc node name Mohammad Rafi Shaik
2023-03-27 16:32 ` [PATCH v1 2/4] dt-bindings: clock: qcom,sc7280-lpasscc: Remove qdsp6ss register region Mohammad Rafi Shaik
2023-03-31 9:29 ` Krzysztof Kozlowski
2023-03-27 16:32 ` [PATCH v1 3/4] arm64: dts: qcom: sc7280: Remove qdsp6ss regmap region Mohammad Rafi Shaik
2023-03-27 16:32 ` [PATCH v1 4/4] clk: qcom: lpasscc-sc7280: Remove qdsp6ss clock registration Mohammad Rafi Shaik
2023-03-29 3:11 ` Stephen Boyd
2023-03-29 9:24 ` Mohammad Rafi Shaik
2023-03-29 17:57 ` Stephen Boyd [this message]
2023-03-31 9:30 ` Krzysztof Kozlowski
2023-03-27 17:41 ` [PATCH v1 0/4] Remove the qdsp6ss register from lpasscc Stephen Boyd
2023-03-28 6:02 ` Mohammad Rafi Shaik
2023-03-28 17:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125013051e5f6578fde8aa006c9bcbd.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_mohs@quicinc.com \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_visr@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox