From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Linas Vepstas <linas@austin.ibm.com>,
John Rose <johnrose@austin.ibm.com>,
akpm@osdl.org, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org, linuxppc64-dev@ozlabs.org,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
Date: Fri, 26 Aug 2005 09:37:36 +1000 [thread overview]
Message-ID: <1125013056.14185.0.camel@gaston> (raw)
In-Reply-To: <17166.20904.543484.435446@cargo.ozlabs.ibm.com>
On Fri, 2005-08-26 at 09:18 +1000, Paul Mackerras wrote:
> Benjamin Herrenschmidt writes:
>
> > Ok, so what is the problem then ? Why do we have to wait at all ? Why
> > not just unplug/replug right away ?
>
> We'd have to be absolutely certain that the driver could not possibly
> take another interrupt or try to access the device on behalf of the
> old instance of the device by the time it returned from the remove
> function. I'm not sure I'd trust most drivers that far...
Hrm... If a driver gets that wrong, then it will also blow up when
unloaded as a module. All drivers should be fully shut down by the time
they return from remove(). free_irq() is synchronous as is iounmap() and
both of those are usually called as part of remove(). I wouldn't be too
worried here.
Ben.
next prev parent reply other threads:[~2005-08-25 23:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050823231817.829359000@bilge>
2005-08-23 23:35 ` [patch 0/8] PCI Error Recovery patchset Linas Vepstas
[not found] ` <20050823232140.337320000@bilge>
2005-08-23 23:39 ` [patch 2/8] PCI Error Recovery: header file patch Linas Vepstas
[not found] ` <20050823232140.520090000@bilge>
2005-08-23 23:41 ` [patch 3/8] PCI Error Recovery: IPR SCSI device driver Linas Vepstas
[not found] ` <20050823232140.903067000@bilge>
2005-08-23 23:43 ` [patch 4/8] PCI Error Recovery: Symbios " Linas Vepstas
[not found] ` <20050823232141.286102000@bilge>
2005-08-23 23:45 ` [patch 5/8] PCI Error Recovery: e100 network " Linas Vepstas
[not found] ` <20050823232141.925586000@bilge>
2005-08-23 23:46 ` [patch 6/8] PCI Error Recovery: e1000 " Linas Vepstas
[not found] ` <20050823232142.651390000@bilge>
2005-08-23 23:47 ` [patch 7/8] PCI Error Recovery: ixgb " Linas Vepstas
[not found] ` <20050823232143.003048000@bilge>
2005-08-23 23:47 ` [patch 8/8] PCI Error Recovery: PPC64 core recovery routines Linas Vepstas
2005-08-24 0:43 ` Paul Mackerras
2005-08-24 4:49 ` Paul Mackerras
2005-08-24 15:45 ` John Rose
2005-08-24 16:29 ` Linas Vepstas
2005-08-25 0:10 ` Paul Mackerras
2005-08-25 0:49 ` Benjamin Herrenschmidt
2005-08-25 16:21 ` Linas Vepstas
2005-08-25 21:43 ` Benjamin Herrenschmidt
2005-08-25 23:18 ` Paul Mackerras
2005-08-25 23:37 ` Benjamin Herrenschmidt [this message]
2005-08-29 16:00 ` Linas Vepstas
2005-08-29 15:57 ` Linas Vepstas
2005-08-25 16:13 ` Linas Vepstas
2005-08-29 6:40 ` Paul Mackerras
2005-08-29 16:09 ` Linas Vepstas
2005-08-30 4:44 ` Paul Mackerras
2005-08-30 22:33 ` John Rose
2005-08-29 20:26 ` John Rose
2005-08-29 20:31 ` John Rose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125013056.14185.0.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=johnrose@austin.ibm.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox