The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "K.R. Foley" <kr@cybsft.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.13-rc7-rt3 compile fix
Date: Fri, 26 Aug 2005 17:36:37 -0400	[thread overview]
Message-ID: <1125092197.5365.50.camel@localhost.localdomain> (raw)
In-Reply-To: <430F86E7.9020605@cybsft.com>

On Fri, 2005-08-26 at 16:17 -0500, K.R. Foley wrote:
> 2.6.13-rc7-rt3 won't compile without the simple patch below.
>  
-       __raw_spin_lock(old_owner->task->pi_lock);
+       __raw_spin_lock(&old_owner->task->pi_lock);
        TRACE_WARN_ON_LOCKED(plist_empty(&waiter->pi_list));
        TRACE_WARN_ON_LOCKED(lock_owner(lock));
 
@@ -683,7 +683,7 @@
        }
        TRACE_WARN_ON_LOCKED(1);
 ok:
-       __raw_spin_unlock(old_owner->task->pi_lock);
+       __raw_spin_unlock(&old_owner->task->pi_lock);
        return;


Oops! my bad.  I saw that needed locking, but I didn't have the tracing
on (I was trying for internal deadlocks), so that part of the code
wasn't compiling.  If you turn off tracing it would compile :-)

Anyway, the next time I modify code that's protected by ifdefs, I'll
change my config and see at least the code compiles.

Thanks,

-- Steve



  reply	other threads:[~2005-08-26 21:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-26 21:17 2.6.13-rc7-rt3 compile fix K.R. Foley
2005-08-26 21:36 ` Steven Rostedt [this message]
2005-08-26 23:43   ` K.R. Foley
2005-08-26 23:56     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1125092197.5365.50.camel@localhost.localdomain \
    --to=rostedt@goodmis.org \
    --cc=kr@cybsft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox