From: Robert Love <rml@novell.com>
To: dtor_core@ameritech.net
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] IBM HDAPS accelerometer driver, with probing.
Date: Fri, 26 Aug 2005 19:37:59 -0400 [thread overview]
Message-ID: <1125099479.32272.29.camel@phantasy> (raw)
In-Reply-To: <d120d50005082615445557d776@mail.gmail.com>
On Fri, 2005-08-26 at 17:44 -0500, Dmitry Torokhov wrote:
> Is this function used in a hot path to warrant using "unlikely"? There
> are to many "unlikely" in the code for my taste.
unlikely() can result in better, smaller, faster code. and it acts as a
nice directive to programmers reading the code.
> input_[un]register_device and del_timer_sync are "long" operations. I
> think a semaphore would be better here.
I was considering moving all locking to a single semaphore, actually.
Robert Love
next prev parent reply other threads:[~2005-08-26 23:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-26 22:18 [patch] IBM HDAPS accelerometer driver, with probing Robert Love
2005-08-26 22:44 ` Dmitry Torokhov
2005-08-26 23:37 ` Robert Love [this message]
2005-08-27 5:29 ` Arnaldo Carvalho de Melo
2005-08-27 14:45 ` Alan Cox
2005-08-26 22:58 ` Alexey Dobriyan
2005-08-26 23:15 ` David S. Miller
2005-08-27 2:34 ` Andi Kleen
2005-08-27 2:49 ` David S. Miller
2005-08-27 4:06 ` Mitchell Blank Jr
2005-08-27 5:34 ` Arnaldo Carvalho de Melo
2005-08-27 6:12 ` Dmitry Torokhov
2005-08-27 11:35 ` Alexey Dobriyan
2005-08-27 14:56 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125099479.32272.29.camel@phantasy \
--to=rml@novell.com \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox