From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Robert Love <rml@novell.com>,
dtor_core@ameritech.net, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] IBM HDAPS accelerometer driver, with probing.
Date: Sat, 27 Aug 2005 15:45:52 +0100 [thread overview]
Message-ID: <1125153952.24593.30.camel@localhost.localdomain> (raw)
In-Reply-To: <20050827052929.GA15782@mandriva.com>
On Sad, 2005-08-27 at 02:29 -0300, Arnaldo Carvalho de Melo wrote:
> > unlikely() can result in better, smaller, faster code. and it acts as a
> > nice directive to programmers reading the code.
>
> Agreed, keep them :-)
If the unlikely() hints are being used correctly and the compiler is
doing the right thing then it ought to be worthwhile, if not then fix
the compiler.
Remember however unlikely() does have a code size cost on some
processors and a small performance cost so it really has to mean
very_unlikely().
next prev parent reply other threads:[~2005-08-27 14:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-26 22:18 [patch] IBM HDAPS accelerometer driver, with probing Robert Love
2005-08-26 22:44 ` Dmitry Torokhov
2005-08-26 23:37 ` Robert Love
2005-08-27 5:29 ` Arnaldo Carvalho de Melo
2005-08-27 14:45 ` Alan Cox [this message]
2005-08-26 22:58 ` Alexey Dobriyan
2005-08-26 23:15 ` David S. Miller
2005-08-27 2:34 ` Andi Kleen
2005-08-27 2:49 ` David S. Miller
2005-08-27 4:06 ` Mitchell Blank Jr
2005-08-27 5:34 ` Arnaldo Carvalho de Melo
2005-08-27 6:12 ` Dmitry Torokhov
2005-08-27 11:35 ` Alexey Dobriyan
2005-08-27 14:56 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125153952.24593.30.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=acme@ghostprotocols.net \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox