Re: [patch 1/1] Hot plug CPU to support physical add of new processors (i386)

[Shaohua Li <shaohua.li@intel.com>]

Hi,
On Wed, 2005-08-31 at 20:13 +0800, Natalie.Protasevich@unisys.com wrote:
> Current IA32 CPU hotplug code doesn't allow bringing up processors
> that were not present in the boot configuration.  
> To make existing hot plug facility more practical for physical hot
> plug, possible processors should be encountered  
> during boot for potentual hot add/replace/remove. On ES7000, ACPI
> marks all the sockets that are empty or not assigned 
> to the partitionas as "disabled". The patch allows arrays/masks with
> APIC info for disabled processors to be  
> initialized. Then the OS can bring up a processor that was inserted in
> the socked and brought into configuration  
> during runtime.  
> To test the code, one can boot the system with maxcpu=1 and then bring
> the rest of the processors up, which was not  
> possible so far (only maxcpus number of nodes were created). 
> The patch also makes proc entry for interrupts dynamically change to
> only show current onlined processors.
Could we clean up the cpu_present_map a bit, like IA64 does? Eg, if a
new CPU is inserted, we allocated cpu id for it and set cpu_present_map.
Current alloc_cpu_id is just a workaround for suspend/resume use, but
isn't ok for physical cpu hotplug to me.

Thanks,
Shaohua