From: Dave Hansen <dave@sr71.net>
To: icampbell@arcom.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
PPC64 External List <linuxppc64-dev@ozlabs.org>
Subject: [RFC] broken installkernel.sh with CROSS_COMPILE
Date: Fri, 02 Sep 2005 13:39:13 -0700 [thread overview]
Message-ID: <1125693554.26605.10.camel@localhost> (raw)
I noticed that my cross-compilation 'make install' broke with 2.6.13 (I
don't use it horribly often). It's from this commit:
http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0f8e2d62fa04441cd12c08ce521e84e5bd3f8a46
Which added CROSS_COMPILE to each arch's install.sh:
if [ -x ~/bin/${CROSS_COMPILE}installkernel ]; then exec ~/bin/${CROSS_COMPILE}installkernel "$@"; fi
However, I don't just have a simple arch name as my CROSS_COMPILE, I
have a whole path, so that line expands like this for me:
+ '[' -x /home/dave/bin//home/services/cross_compile/ppc64/bin/ppc64-linux-gnu-installkernel ']'
Needless to say, that doesn't work :)
Could we do something that's guaranteed to not have lots of extra path
elements in it, like ARCH? Something like this?
That way, people like me who have a single installkernel script that
does all of the fancy arch-detection can just do this:
for i in `ls linux-2.6.git/arch/`; do
ln -s ~/bin/installkernel ~/bin/$i-installkernel
fi
And be done with it forever.
--- linux-2.6/arch/ppc64/boot/install.sh.orig 2005-09-02 13:34:16.000000000 -0700
+++ linux-2.6/arch/ppc64/boot/install.sh 2005-09-02 13:34:52.000000000 -0700
@@ -22,6 +22,7 @@
# User may have a custom install script
+if [ -x ~/bin/${ARCH}-installkernel ]; then exec ~/bin/${ARCH}-installkernel "$@"; fi
if [ -x ~/bin/${CROSS_COMPILE}installkernel ]; then exec ~/bin/${CROSS_COMPILE}installkernel "$@"; fi
if [ -x /sbin/${CROSS_COMPILE}installkernel ]; then exec /sbin/${CROSS_COMPILE}installkernel "$@"; fi
-- Dave
next reply other threads:[~2005-09-02 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-02 20:39 Dave Hansen [this message]
2005-09-03 8:50 ` [RFC] broken installkernel.sh with CROSS_COMPILE Ian Campbell
2005-09-03 12:31 ` Dave Hansen
2005-09-03 14:35 ` Ian Campbell
2005-09-07 22:35 ` linas
2005-09-07 22:53 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125693554.26605.10.camel@localhost \
--to=dave@sr71.net \
--cc=icampbell@arcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox