Re: 2.6.13-mm1

["J.A. Magallon" <jamagallon@able.es>]

On 09.02, Andrew Morton wrote:
> "J.A. Magallon" <jamagallon@able.es> wrote:
> >
> > 
> > On 09.02, Andrew Morton wrote:
> > > "J.A. Magallon" <jamagallon@able.es> wrote:
> > > >
> > > > 
> > > > On 1/09/2005 10:58 a.m., Andrew Morton wrote:
> > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13/2.6.13-mm1/
> > > > > 
> > > > > - Included Alan's big tty layer buffering rewrite.  This breaks the build on
> > > > >   lots of more obscure character device drivers.  Patches welcome (please cc
> > > > >   Alan).
> > > > > 
> > > > 
> > > > I have problems with udev and latest -mm.
> > > > 2.6.13 boots fine, but 2.6.13-mm1 blocks when starting udev.
> > > > System is Mandriva Cooker. As cooker, things are changing fast (initscripts,
> > > > udev, etc), but the fact is that with the same setup, plain .13 boots
> > > > and -mm1 blocks. Udev is 068 version.
> > > > 
> > > > Any idea about what can be the reason ?
> > > > 
> > > 
> > > There's some suspect locking in the /proc/devices seq_file conversion code.
> > > 
> > > Could you revert convert-proc-devices-to-use-seq_file-interface-fix.patch
> > > then convert-proc-devices-to-use-seq_file-interface.patch?
> > > 
> > 
> > Still the same result, system bocks starting udev...
> > 
> 
> OK, thanks.   Nothing from sysrq-t?  Does the below help?
> 
> --- devel/fs/sysfs/file.c~gregkh-driver-sysfs-strip_leading_trailing_whitespace-fix	2005-09-02 04:01:40.000000000 -0700
> +++ devel-akpm/fs/sysfs/file.c	2005-09-02 04:05:02.000000000 -0700
> @@ -202,13 +202,14 @@ fill_write_buffer(struct sysfs_buffer * 
>   *	passing the buffer that we acquired in fill_write_buffer().
>   */
>  
> -static int 
> -flush_write_buffer(struct dentry * dentry, struct sysfs_buffer * buffer, size_t count)
> +static int flush_write_buffer(struct dentry *dentry,
> +			struct sysfs_buffer *buffer, size_t count_in)
>  {
>  	struct attribute * attr = to_attr(dentry);
>  	struct kobject * kobj = to_kobj(dentry->d_parent);
>  	struct sysfs_ops * ops = buffer->ops;
>  	char *x;
> +	size_t count = count_in;
>  
>  	/* locate trailing white space */
>  	while ((count > 0) && isspace(buffer->page[count - 1]))
> @@ -224,7 +225,8 @@ flush_write_buffer(struct dentry * dentr
>  	/* terminate the string */
>  	x[count] = '\0';
>  
> -	return ops->store(kobj, attr, x, count);
> +	ops->store(kobj, attr, x, count);
> +	return count_in;
>  }
>  

Bingo !.

That did the trink. Booting fine again.
I meant, just with this, without reverting the other 2 patches.

Thanks !

--
J.A. Magallon <jamagallon()able!es>     \               Software is like sex:
werewolf!able!es                         \         It's better when it's free
Mandriva Linux release 2006.0 (Cooker) for i586
Linux 2.6.13-jam2 (gcc 4.0.1 (4.0.1-5mdk for Mandriva Linux release 2006.0))