Re: [PATCH 9/12] kbuild: mips use generic asm-offsets.h support

Sam Ravnborg
2005-09-10T20:46:43Z

Hi Roman.

> > kbuild looks for the Kbuild file before it looks for Makefile.
> > In a desire to move some of the functionality away form the top-level
> > Makefile and in to a kbuild file this is needed.
>
> Why don't you put it into scripts/Makefile...?
Because it does not build a build-support program.
That would be the last place where one would look for
rules to build asm-offsets.h for example.
When the functionalty to start the recursive build of all kernel
directories are moved to top-level Kbuild the location in the
top-level directory makes even more sense.

Same goes when the post processing steps are moved to the top-level
Kbuild file. Here we again will benefit form having the full kbuild
funtionality available.

> > The Kbuild file in the top-level directory will take
> > over more and more functionality from the top-level
> > Makefile to the extent that I hope to end up with two
> > readable files.
>
> If the top-level Makefile gets to big, we can move things into scripts/,
> that's really no reason to start using Kbuild, in the end it's still a
> Makefile and I'd prefer to call it like that.
A makefile is a file that does something intelligent when used as input
to make. It is long time since this property did not hold for the
kernel.
The Kbuild name is a much more natural name in the respect that it
tells you this file contain kbuild info. So one know when browsing
a directory structure that a Kbuild file is input to kbuild, and follow
a much more strict syntax than ordinary Makefiles.

Sam