Re: [PATCH 9/12] kbuild: mips use generic asm-offsets.h support

Roman Zippel
2005-09-10T21:09:49Z

Hi,

On Sat, 10 Sep 2005, Sam Ravnborg wrote:

> > Why don't you put it into scripts/Makefile...?
> Because it does not build a build-support program.
> That would be the last place where one would look for
> rules to build asm-offsets.h for example.

Weird, why are the rules to build *.o files in scripts/Makefile.build?

> Same goes when the post processing steps are moved to the top-level
> Kbuild file. Here we again will benefit form having the full kbuild
> funtionality available.

So why is this benefit only available via Kbuild?
If the toplevel Makefile is to crowded, why don't you move things into
scripts/?

> > If the top-level Makefile gets to big, we can move things into scripts/,
> > that's really no reason to start using Kbuild, in the end it's still a
> > Makefile and I'd prefer to call it like that.
> A makefile is a file that does something intelligent when used as input
> to make. It is long time since this property did not hold for the
> kernel.
> The Kbuild name is a much more natural name in the respect that it
> tells you this file contain kbuild info. So one know when browsing
> a directory structure that a Kbuild file is input to kbuild, and follow
> a much more strict syntax than ordinary Makefiles.

If we continue in this direction, it would be even more natural to merge
the Makefile with Kconfig, so I don't see the point in introducing Kbuild
in first place, if we later remove it again anyway.

bye, Roman