Re: [PATCH] include: pci_find_device remove (include/asm-i386/ide.h)

Grant Grundler
2005-09-11T01:18:23Z

On Sun, Sep 11, 2005 at 02:06:56AM +0100, Alan Cox wrote:
> On Sad, 2005-09-10 at 18:34 -0600, Grant Grundler wrote:
> > If ide_scan_pcibus() finds any pci device, it calls ide_scan_pcidev().
> > ide_scan_pcidev() only seems to handle PCI devices.
> > Are you saying there are PCI IDE devices out there that
> > don't advertise PCI_CLASS_STORAGE_IDE?
>
> Lots of them. We also want to know if PCI is present so we can know
> whether to do the IDE tertiary scan which isn't safe on a PCI bus box.

ah ok. I'm not seeing where that happens.

Anyway, pci_present() could be as simple as "(pci_root_buses!=NULL)".

ide_system_bus_speed() in drivers/ide/ide.c might want this too.

BTW, I'm not convinced the current code does *exactly* what you want.
Hypothetically, we can have a PCI bus but no PCI devices.
Maybe no such system exists but I wouldn't bet on it.

thanks,
grant