From: Arjan van de Ven <arjanv@redhat.com>
To: Stefan Smietanowski <stesmi@stesmi.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
Harald Welte <laforge@gnumonks.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2/2] New Omnikey Cardman 4000 driver
Date: Wed, 14 Sep 2005 07:42:25 -0400 [thread overview]
Message-ID: <1126698145.3159.2.camel@localhost.localdomain> (raw)
In-Reply-To: <43280793.8070809@stesmi.com>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Wed, 2005-09-14 at 13:20 +0200, Stefan Smietanowski wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Andrew Morton wrote:
> > Harald Welte <laforge@gnumonks.org> wrote:
> >
> >>Add new Omnikey Cardman 4000 smartcard reader driver
> >
> >
> > - All the open-coded mdelays() are wrong:
> >
> > #define T_10MSEC msecs_to_jiffies(10)
> > ...
> > mdelay(T_10MSEC);
> >
> > mdelay() already takes a jiffies argument.
>
> And isn't that what he's doing?
Andrew had a slippian freud; mdelay takes miliseconds as argument.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-09-14 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 15:53 [PATCH 2/2] New Omnikey Cardman 4000 driver Harald Welte
2005-09-14 9:23 ` Andrew Morton
2005-09-14 11:20 ` Stefan Smietanowski
2005-09-14 11:42 ` Arjan van de Ven [this message]
2005-09-18 21:22 ` [PATCH] Omnikey CardMan 4000 update Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126698145.3159.2.camel@localhost.localdomain \
--to=arjanv@redhat.com \
--cc=akpm@osdl.org \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stesmi@stesmi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox