From: Nigel Cunningham <ncunningham@cyclades.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Li Shaohua <shaohua.li@intel.com>,
vatsa@in.ibm.com, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
lkml <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: PATCH: Fix race in cpu_down (hotplug cpu)
Date: Mon, 19 Sep 2005 16:54:29 +1000 [thread overview]
Message-ID: <1127112869.9696.107.camel@localhost> (raw)
In-Reply-To: <1127111784.5272.10.camel@npiggin-nld.site>
Hi.
On Mon, 2005-09-19 at 16:36, Nick Piggin wrote:
> On Mon, 2005-09-19 at 14:37 +0800, Shaohua Li wrote:
> > On Mon, 2005-09-19 at 11:53 +0530, Srivatsa Vaddagiri wrote:
>
> > > default_idle should be fine as it is. IOW it should not cause __cpu_die to
> > > timeout.
> > Why default_idle should be fine? it can be preempted before the
> > 'local_irq_disable' check. Even with Nigel's patch, there is a very
> > small window at safe_halt (after 'sti' but before 'hlt').
> >
>
> Ah, actually I have a patch which makes all CPU idle threads
> run with preempt disabled and only enable preempt when scheduling.
> Would that help?
Sounds to me like it should, but I'm not claiming any expertise in this
area. Going off your other posts, you're thinking of this plus my
original patch?
Regards,
Nigel
next prev parent reply other threads:[~2005-09-19 6:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-19 4:48 PATCH: Fix race in cpu_down (hotplug cpu) Li, Shaohua
2005-09-19 5:10 ` Srivatsa Vaddagiri
2005-09-19 5:31 ` Shaohua Li
2005-09-19 5:57 ` Srivatsa Vaddagiri
2005-09-19 6:11 ` Nigel Cunningham
2005-09-19 6:23 ` Srivatsa Vaddagiri
2005-09-19 6:29 ` Nick Piggin
2005-09-19 7:00 ` Srivatsa Vaddagiri
2005-09-19 6:31 ` Nigel Cunningham
2005-09-19 7:09 ` Srivatsa Vaddagiri
2005-09-19 6:37 ` Shaohua Li
2005-09-19 6:36 ` Nick Piggin
2005-09-19 6:54 ` Nigel Cunningham [this message]
2005-09-19 7:12 ` Shaohua Li
2005-09-19 7:22 ` Nick Piggin
2005-09-19 7:28 ` Ingo Molnar
2005-09-19 7:37 ` Nick Piggin
2005-09-19 22:55 ` Nigel Cunningham
2005-09-20 4:41 ` Srivatsa Vaddagiri
2005-09-19 7:07 ` Srivatsa Vaddagiri
2005-09-19 5:23 ` Nigel Cunningham
2005-09-19 5:28 ` Srivatsa Vaddagiri
2005-09-19 5:35 ` Nigel Cunningham
2005-09-19 7:43 ` Where do packets sent to 255.255.255.255 go? Wei-Che, Hsu
-- strict thread matches above, loose matches on Subject: below --
2005-09-19 3:28 PATCH: Fix race in cpu_down (hotplug cpu) Nigel Cunningham
2005-09-19 4:22 ` Srivatsa Vaddagiri
2005-09-19 3:15 Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1127112869.9696.107.camel@localhost \
--to=ncunningham@cyclades.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=rusty@rustcorp.com.au \
--cc=shaohua.li@intel.com \
--cc=torvalds@osdl.org \
--cc=vatsa@in.ibm.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox