Re: [patch] stop inotify from sending random DELETE_SELF event under load

Christoph Hellwig
2005-09-21T08:35:41Z

On Wed, Sep 21, 2005 at 03:36:01AM +0100, Al Viro wrote:
> On Tue, Sep 20, 2005 at 09:41:47PM -0400, John McCutchan wrote:
> > I grepped all the filesystems
>
> ... in the tree
>
> > , and they all seem to use
> > generic_drop_inode, except for hugetlbfs, which seems to have the same
> > logic of (!inode->i_nlink).
>
> I have no problems with killing ->drop_inode(), but that should be
> a) done for in-tree filesystems
> b) announced on fsdevel, so that out-of-tree folks could deal
> with that
> c) given at least one release to avoid screwing them.
>
> Christoph, could you send the patch you've mentioned? I'd rather avoid
> duplicating what you've done...

sure. Note that clusterfs folks (ocfs2 in particular) really want
->drop_inode because they need additional checks instead of just the
nlink one in there. While hugetlbfs should just go away ->drop_inode
makes some sense for them.