From: Norbert Kiesel <nkiesel@tbdnetworks.com>
To: linux-kernel@vger.kernel.org
Cc: Jens Axboe <axboe@suse.de>
Subject: [PATCH] trivial: delete 2 unreachable statements in drivers/block/paride/pf.c
Date: Tue, 20 Sep 2005 10:37:21 -0700 [thread overview]
Message-ID: <1127237842.4416.28.camel@defiant> (raw)
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
Hi,
the last patch from Jens Axboe for drivers/block/paride/pf.c
introduced pf_end_request() which sets pf_req to NULL. The trivial
patch below deletes 2 unreachable statements. I asked Jens about it
and he said: "Yeah that is a leftover, harmless though."
Best,
Norbert
diff -u a/drivers/block/paride/pf.c b/drivers/block/paride/pf.c
--- a/drivers/block/paride/pf.c 2005-09-20 10:24:54.000000000 -0700
+++ b/drivers/block/paride/pf.c 2005-09-20 10:25:55.000000000 -0700
@@ -807,10 +807,6 @@
return 1;
spin_lock_irqsave(&pf_spin_lock, saved_flags);
pf_end_request(1);
- if (pf_req) {
- pf_count = pf_req->current_nr_sectors;
- pf_buf = pf_req->buffer;
- }
spin_unlock_irqrestore(&pf_spin_lock, saved_flags);
return 1;
}
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
reply other threads:[~2005-09-20 17:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1127237842.4416.28.camel@defiant \
--to=nkiesel@tbdnetworks.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox