From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbbJLJaU (ORCPT ); Mon, 12 Oct 2015 05:30:20 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:59230 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbbJLJaR (ORCPT ); Mon, 12 Oct 2015 05:30:17 -0400 From: Arnd Bergmann To: Neil Brown Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Goldwyn Rodrigues , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] md: fix 32-bit build warning Date: Mon, 12 Oct 2015 11:30:11 +0200 Message-ID: <11281560.gJ28rX782P@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <87fv1g1y34.fsf@notabene.neil.brown.name> References: <5304496.D8N6u074t0@wuerfel> <87fv1g1y34.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:zYgbqRHKjNq4je7hy5LGlynLN3MY0dhWojqMLda4JLyjZkPMkYL H+dfbcCe0nQOAgA0nHpG9eS4MzcY3FQ6fdX+40iMvcgEa2ATHun6RPoSHckmiFTPGjhZ7XG omuNrNzoJqTb95QDxlxgZttbPc47wwbpz6Tm/9++Fk0yqy24Chgu+KgdFVL4Y0cKTvzb161 HWCAU4U2iFkSBzPJAaN3g== X-UI-Out-Filterresults: notjunk:1;V01:K0:a6+Sbqbu8KM=:JK3Yv5ymBP9XRmT8m+Tsel RiA3Of4d4jiL9g1kBqkCP8avvolmYvlBVtbPO/plqfpA7vMEPhgFRIoQ2fPxqo33WWWyedMdZ ihvjbjS4tO5dS3GK69pnbVX/4korlYzbBA2OTlYZ0GO/wtnqUrfY7S894KKJtIPn+zQw2YrS3 PZxeDGfqv1afqFVcboHnxFLF+F2SZdFLz8XhSrSlGddeWL6FQSM5qVqb8PYXusCN7gFL+WtLf WLsvU5YANsxg0uQzajr4NXRStink6xNA5ywXxxkAkZ32dm2RcKGDxklPvlEMABgKhIF9/Y/0e hx60VyBP8RSBdgQ0fNqW0yPQpvwRrjjJg1A02BbttRSvwsjhMh38/mjWnmfOjc1xUasKYa5xT JxI84DOh/uoqDawVDIW9yYe4E1uQnw2PtYhmYrY0N5Rx+TBWEzzbmYrLSKXqI3gSScT3ID/qf pm57YuHGa/USCZCgv8QetgNrCdEinwcLBIyAAmBDF7ZgoJG0RPjmBD+v1I67coqKG532nWRPv oYUK2J3viPWRTnkln//lIUjfdah8LV0XNzfj/jSgYxit1IH36HicXYZddzZngkNffA1+ZouMD S8W1W+3IoxgRNWnHwVSNDBJS3hyL12nunySi3GjH57K7o3M8O011cgB6OMtCY1YNBwvZ4qF0e 5rL3HTCD2nRjMFvSmNPneRUME4wIgW/tSuQkHqKattfDlrjthfDOQrEezEV9EGrbihVtrQ/nc 7jHWX8K1Ft5gsowS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 12 October 2015 15:59:27 Neil Brown wrote: > > diff --git a/drivers/md/md.c b/drivers/md/md.c > > index 7fff1e6884d6..e13f72a3b561 100644 > > --- a/drivers/md/md.c > > +++ b/drivers/md/md.c > > @@ -8987,9 +8987,9 @@ static void check_sb_changes(struct mddev *mddev, struct md_rdev *rdev) > > > > /* recovery_cp changed */ > > if (le64_to_cpu(sb->resync_offset) != mddev->recovery_cp) { > > - pr_info("%s:%d recovery_cp changed from %lu to %lu\n", __func__, > > - __LINE__, mddev->recovery_cp, > > - (unsigned long) le64_to_cpu(sb->resync_offset)); > > + pr_info("%s:%d recovery_cp changed from %llu to %llu\n", __func__, > > + __LINE__, (u64)mddev->recovery_cp, > > + (u64) le64_to_cpu(sb->resync_offset)); > > mddev->recovery_cp = le64_to_cpu(sb->resync_offset); > > } > > > > Thanks, but is this really right? > I think u64 is "unsigned long" on 64bit. > I have always used (unsigned long long) when I want to use %llu on > sector_t. > > How confident are you of using "u64" ? Very confident ;-) This used to not work until some linux-2.6 version when we changed all architectures to use asm-generic/int-ll64.h in the kernel, because a lot of code relied on printing u64 variables using %lld. I tend to use u64 for things like this because it's shorter than 'unsigned long long'. Arnd