Re: [PATCH 1/7] AMD Geode GX/LX support

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

On Llu, 2005-10-03 at 11:47 -0600, Jordan Crouse wrote:
> +	  - "Geode GX" for AMD Geode GX processors
>  	  - "Crusoe" for the Transmeta Crusoe series.
>  	  - "Efficeon" for the Transmeta Efficeon series.
>  	  - "Winchip-C6" for original IDT Winchip.

Whats wrong with the existing MGEODEGX1 define (other than it doesn't
say AMD)



>  config X86_USE_3DNOW
>  	bool
> -	depends on MCYRIXIII || MK7
> +	depends on MCYRIXIII || MK7 || MGEODE_GX
>  	default y

Is this correct - last time I benchmarked it the older GEODE was better
off using non MMX copies ?

>  
>  config X86_OOSTORE
> @@ -532,7 +539,7 @@ source "kernel/Kconfig.preempt"
>  
>  config X86_UP_APIC
>  	bool "Local APIC support on uniprocessors"
> -	depends on !SMP && !(X86_VISWS || X86_VOYAGER)
> +	depends on !SMP && !(X86_VISWS || X86_VOYAGER || MGEODE_GX)
>  	help

This is wrong - a GEODE kernel can support APIC even if the Geode itself
doesn't. Remeber it is *optimised for at least... * not "xyz only"

> +	depends on !MGEODE_GX
>  	help
>  	  Select this if you have a 32-bit processor and more than 4
>  	  gigabytes of physical RAM.

Ditto

> +                           clear_bit(0*32+16, &c->x86_capability);
> +                           clear_bit(0*32+24, &c->x86_capability);
> +
> +                           since I don't think the kernel supports
> +                           FPU-CMOV or Cyrix MMX.  Unsure tho.

Kernel space enables Cyrix MMX on the processors it knows about that it
can. Some userspace will use the extensions if present. The Cyrix init
code you unplugged it from knows how to do this which your unfinished
patch doesn't.