From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932281AbVJQLmW (ORCPT ); Mon, 17 Oct 2005 07:42:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932280AbVJQLmV (ORCPT ); Mon, 17 Oct 2005 07:42:21 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:41894 "EHLO e35.co.us.ibm.com") by vger.kernel.org with ESMTP id S932277AbVJQLmU (ORCPT ); Mon, 17 Oct 2005 07:42:20 -0400 Subject: Re: [Patch 2/3] Export get_one_pte_map. From: Dave Hansen To: Robin Holt Cc: Greg KH , ia64 list , linux-mm , Linux Kernel Mailing List , hch@infradead.org, jgarzik@pobox.com, William Lee Irwin III , Jack Steiner In-Reply-To: <20051017113131.GA30898@lnx-holt.americas.sgi.com> References: <20051014192111.GB14418@lnx-holt.americas.sgi.com> <20051014192225.GD14418@lnx-holt.americas.sgi.com> <20051014213038.GA7450@kroah.com> <20051017113131.GA30898@lnx-holt.americas.sgi.com> Content-Type: text/plain Date: Mon, 17 Oct 2005 13:41:52 +0200 Message-Id: <1129549312.32658.32.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2005-10-17 at 06:31 -0500, Robin Holt wrote: > On Fri, Oct 14, 2005 at 02:30:38PM -0700, Greg KH wrote: > > On Fri, Oct 14, 2005 at 02:22:25PM -0500, Robin Holt wrote: > > > +EXPORT_SYMBOL(get_one_pte_map); > > > > EXPORT_SYMBOL_GPL() ? > > Not sure why it would fall that way. Looking at the directory, > I get: Most of the VM stuff in those directories that you're referring to are old, crusty exports, from the days before _GPL. We've left them to be polite, but if many of them were recreated today, they'd certainly be _GPL. We do not want random external modules poking at PTEs, nor should a module need to know such kernel internals as the semantics of PTE_HIGHMEM. I think it needs _GPL. BTW, your new patches look much nicer than the last set. Thanks for making the changes I suggested. -- Dave