2.6.14-rc4-mm1 ntfs/namei.c missing compat.h?

2.6.14-rc4-mm1 ntfs/namei.c missing compat.h?

[nyk]

Hi,

Looks like fs/ntfs/namei.c is missing linux/compat.h

  CHK     include/linux/version.h
  CHK     include/linux/compile.h
  CHK     usr/initramfs_list
  CC [M]  fs/ntfs/namei.o
In file included from include/linux/dcache.h:6,
                 from fs/ntfs/namei.c:23:
include/asm/atomic.h:383: error: syntax error before '*' token
include/asm/atomic.h:384: warning: function declaration isn't a prototype
include/asm/atomic.h: In function 'atomic_scrub':
include/asm/atomic.h:385: error: 'u32' undeclared (first use in this function)
include/asm/atomic.h:385: error: (Each undeclared identifier is reported only once
include/asm/atomic.h:385: error: for each function it appears in.)
include/asm/atomic.h:385: error: syntax error before 'i'
include/asm/atomic.h:386: error: 'i' undeclared (first use in this function)
include/asm/atomic.h:386: error: 'size' undeclared (first use in this function)
include/asm/atomic.h:386: error: 'virt_addr' undeclared (first use in this function)
include/asm/atomic.h:386: warning: left-hand operand of comma expression has no effect
include/asm/atomic.h:386: warning: statement with no effect
include/asm/atomic.h:390: error: memory input 0 is not directly addressable
make[2]: *** [fs/ntfs/namei.o] Error 1
make[1]: *** [fs/ntfs] Error 2
make: *** [fs] Error 2

Compiles fine with #include <linux/compat.h> added to the top of
fs/ntfs/namei.c

If that's the right place for it, of course.

hth
Nyk
-- 
/__
\_|\/
   /\

Re: 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h?

[Anton Altaparmakov]

On Mon, 2005-10-17 at 15:49 +0100, nyk wrote:
> Looks like fs/ntfs/namei.c is missing linux/compat.h
> 
>   CHK     include/linux/version.h
>   CHK     include/linux/compile.h
>   CHK     usr/initramfs_list
>   CC [M]  fs/ntfs/namei.o
> In file included from include/linux/dcache.h:6,
>                  from fs/ntfs/namei.c:23:
> include/asm/atomic.h:383: error: syntax error before '*' token
> include/asm/atomic.h:384: warning: function declaration isn't a prototype
> include/asm/atomic.h: In function 'atomic_scrub':
> include/asm/atomic.h:385: error: 'u32' undeclared (first use in this function)
> include/asm/atomic.h:385: error: (Each undeclared identifier is reported only once
> include/asm/atomic.h:385: error: for each function it appears in.)
> include/asm/atomic.h:385: error: syntax error before 'i'
> include/asm/atomic.h:386: error: 'i' undeclared (first use in this function)
> include/asm/atomic.h:386: error: 'size' undeclared (first use in this function)
> include/asm/atomic.h:386: error: 'virt_addr' undeclared (first use in this function)
> include/asm/atomic.h:386: warning: left-hand operand of comma expression has no effect
> include/asm/atomic.h:386: warning: statement with no effect
> include/asm/atomic.h:390: error: memory input 0 is not directly addressable
> make[2]: *** [fs/ntfs/namei.o] Error 1
> make[1]: *** [fs/ntfs] Error 2
> make: *** [fs] Error 2
> 
> Compiles fine with #include <linux/compat.h> added to the top of
> fs/ntfs/namei.c
> 
> If that's the right place for it, of course.

Odd.  Compiles fine on non-mm kernel here.  Can you send me
your .config?  (And which architecture are you using?)

Thanks.

/me goes away to download -mm...

Best regards,

        Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/

[patch] Re: 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h?

[Tim Schmielau]

On Mon, 17 Oct 2005, nyk wrote:

> Looks like fs/ntfs/namei.c is missing linux/compat.h
> 
>   CHK     include/linux/version.h
>   CHK     include/linux/compile.h
>   CHK     usr/initramfs_list
>   CC [M]  fs/ntfs/namei.o
> In file included from include/linux/dcache.h:6,
>                  from fs/ntfs/namei.c:23:
> include/asm/atomic.h:383: error: syntax error before '*' token
> include/asm/atomic.h:384: warning: function declaration isn't a prototype
> include/asm/atomic.h: In function 'atomic_scrub':
> include/asm/atomic.h:385: error: 'u32' undeclared (first use in this function)
> include/asm/atomic.h:385: error: (Each undeclared identifier is reported only once
[...]
> 
> Compiles fine with #include <linux/compat.h> added to the top of
> fs/ntfs/namei.c
> 
> If that's the right place for it, of course.

[Looks like you are on x86_64, as i386 compiles fine]

Actually, <asm-x86_64/atomic.h> seems to need <asm/types.h> for the 
declaration of u32.
The patch below makes NTFS compile on x86_64 for me. Andi?

Tim


--- linux-2.6.14-rc4-mm1/include/asm-x86_64/atomic.h	2005-10-17 17:48:12.000000000 +0200
+++ linux-2.6.14-rc4-mm1-build/include/asm-x86_64/atomic.h	2005-10-17 18:20:19.000000000 +0200
@@ -2,6 +2,7 @@
 #define __ARCH_X86_64_ATOMIC__
 
 #include <linux/config.h>
+#include <asm/types.h>
 
 /* atomic_t should be 32 bit signed type */
 

Re: [patch] Re: 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h?

[Andi Kleen]

On Monday 17 October 2005 18:33, Tim Schmielau wrote:

>
> [Looks like you are on x86_64, as i386 compiles fine]
>
> Actually, <asm-x86_64/atomic.h> seems to need <asm/types.h> for the
> declaration of u32.
> The patch below makes NTFS compile on x86_64 for me. Andi?
>
> Tim

-mm specific problem caused by the bluesmoke merges.

IMHO the right fix is to put that atomic scrub thingy into another include
file. It seems to cause major additional include dependencies and 
is only used in a single file right now.

-Andi

>
> --- linux-2.6.14-rc4-mm1/include/asm-x86_64/atomic.h	2005-10-17
> 17:48:12.000000000 +0200 +++
> linux-2.6.14-rc4-mm1-build/include/asm-x86_64/atomic.h	2005-10-17
> 18:20:19.000000000 +0200 @@ -2,6 +2,7 @@
>  #define __ARCH_X86_64_ATOMIC__
>
>  #include <linux/config.h>
> +#include <asm/types.h>
>
>  /* atomic_t should be 32 bit signed type */

Re: [patch] Re: 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h?

[Alan Cox]

On Llu, 2005-10-17 at 18:41 +0200, Andi Kleen wrote:
> IMHO the right fix is to put that atomic scrub thingy into another include
> file. It seems to cause major additional include dependencies and 
> is only used in a single file right now.

Every file I looked at (I've not looked at NTFS) included types.h if it
included atomic.h but sometimes directly or indirectly after atomic.h
rather than before.

I was thinking of just writing a tool to find the other cases and then
fix those I can.

Re: [patch] Re: 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h?

[Andi Kleen]

On Monday 17 October 2005 20:01, Alan Cox wrote:
> On Llu, 2005-10-17 at 18:41 +0200, Andi Kleen wrote:
> > IMHO the right fix is to put that atomic scrub thingy into another
> > include file. It seems to cause major additional include dependencies and
> > is only used in a single file right now.
>
> Every file I looked at (I've not looked at NTFS) included types.h if it
> included atomic.h but sometimes directly or indirectly after atomic.h
> rather than before.
>
> I was thinking of just writing a tool to find the other cases and then
> fix those I can.

I think it is far better you do it in a different macro in a different file
without any nasty dependencies. What you're trying to do has nothing
to do with atomic_t anyways. It is just abuse of atomic.h

-Andi

Re: [patch] Re: 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h?

[nyk]

On Mon, Oct 17, 2005 at 06:33:58PM +0200, Tim Schmielau wrote:
> On Mon, 17 Oct 2005, nyk wrote:
> 
> > Looks like fs/ntfs/namei.c is missing linux/compat.h
> > 
> >   CHK     include/linux/version.h
> >   CHK     include/linux/compile.h
> >   CHK     usr/initramfs_list
> >   CC [M]  fs/ntfs/namei.o
> > In file included from include/linux/dcache.h:6,
> >                  from fs/ntfs/namei.c:23:
> > include/asm/atomic.h:383: error: syntax error before '*' token
> > include/asm/atomic.h:384: warning: function declaration isn't a prototype
> > include/asm/atomic.h: In function 'atomic_scrub':
> > include/asm/atomic.h:385: error: 'u32' undeclared (first use in this function)
> > include/asm/atomic.h:385: error: (Each undeclared identifier is reported only once
> [...]
> > 
> > Compiles fine with #include <linux/compat.h> added to the top of
> > fs/ntfs/namei.c
> > 
> > If that's the right place for it, of course.
> 
> [Looks like you are on x86_64, as i386 compiles fine]
> 
> Actually, <asm-x86_64/atomic.h> seems to need <asm/types.h> for the 
> declaration of u32.
> The patch below makes NTFS compile on x86_64 for me. Andi?
> 
> Tim
> 
> 
> --- linux-2.6.14-rc4-mm1/include/asm-x86_64/atomic.h	2005-10-17 17:48:12.000000000 +0200
> +++ linux-2.6.14-rc4-mm1-build/include/asm-x86_64/atomic.h	2005-10-17 18:20:19.000000000 +0200
> @@ -2,6 +2,7 @@
>  #define __ARCH_X86_64_ATOMIC__
>  
>  #include <linux/config.h>
> +#include <asm/types.h>
>  
>  /* atomic_t should be 32 bit signed type */
>  

Yup x86_64. And trying out bluesmoke, but I got a lot of unknown symbols
in ehci_hcd, so I've got problems elsewhere as well. Will try a compile
from a clean tree...

Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_hcd_pci_suspend
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_free_urb
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_hub_tt_clear_buffer
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_hcd_pci_probe
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_suspend_device
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_disabled
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_put_dev
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_get_dev
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_calc_bus_time
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_hcd_pci_resume
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_get_urb
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_hcd_giveback_urb
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_set_device_state
Oct 17 20:24:42 natsu kernel: ehci_hcd: Unknown symbol usb_hcd_pci_remove

Nyk
-- 
/__
\_|\/
   /\