From: Adam Litke <agl@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Rohit Seth <rohit.seth@intel.com>,
linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH]: Handling spurious page fault for hugetlb region for 2.6.14-rc4-git5
Date: Wed, 19 Oct 2005 09:33:07 -0500 [thread overview]
Message-ID: <1129732387.8702.30.camel@localhost.localdomain> (raw)
In-Reply-To: <20051018210721.4c80a292.akpm@osdl.org>
On Tue, 2005-10-18 at 21:07 -0700, Andrew Morton wrote:
> Rohit Seth <rohit.seth@intel.com> wrote:
> >
> > The prefetching problem is handled OK for regular pages because we can
> > handle page faults corresponding to those pages. That is currently not
> > true for hugepages. Currently the kernel assumes that PAGE_FAULT
> > happening against a hugetlb page is caused by truncate and returns
> > SIGBUS.
>
> Doh. No fault handler. The penny finally drops.
>
> Adam, I think this patch is temporary?
Yeah, looks like it can be dropped now since we handle this case (in
hugetlb_fault) as:
> size = i_size_read(mapping->host) >> HPAGE_SHIFT;
> if (idx >= size)
> goto backout;
>
> ret = VM_FAULT_MINOR;
> if (!pte_none(*pte))
> goto backout;
--
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center
next prev parent reply other threads:[~2005-10-19 14:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-18 21:15 [PATCH]: Handling spurious page fault for hugetlb region for 2.6.14-rc4-git5 Seth, Rohit
2005-10-18 21:34 ` Andrew Morton
2005-10-18 22:17 ` Rohit Seth
2005-10-19 0:25 ` Andrew Morton
2005-10-19 3:25 ` Rohit Seth
2005-10-19 4:07 ` Andrew Morton
2005-10-19 14:33 ` Adam Litke [this message]
2005-10-19 15:48 ` Hugh Dickins
2005-10-19 19:05 ` Rohit Seth
2005-10-19 20:00 ` Hugh Dickins
2005-10-19 20:19 ` Andrew Morton
2005-10-19 20:28 ` Hugh Dickins
2005-10-19 23:53 ` Rohit Seth
2005-10-20 1:36 ` Rohit Seth
2005-10-20 1:37 ` Andrew Morton
2005-10-20 6:17 ` Hugh Dickins
2005-10-19 15:23 ` Hugh Dickins
2005-10-19 18:47 ` Rohit Seth
2005-10-19 20:53 ` Linus Torvalds
2005-10-19 21:59 ` Tony Luck
2005-10-20 0:05 ` Rohit Seth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129732387.8702.30.camel@localhost.localdomain \
--to=agl@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rohit.seth@intel.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox