From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, Dmitry Torokhov <dtor@mail.ru>
Subject: Re: [PATCH] bluetooth hidp is broken on s390
Date: Mon, 31 Oct 2005 10:01:00 +0100 [thread overview]
Message-ID: <1130749260.5863.12.camel@localhost.localdomain> (raw)
In-Reply-To: <20051029184758.GL7992@ftp.linux.org.uk>
On Sat, 2005-10-29 at 19:47 +0100, Al Viro wrote:
> On Sat, Oct 29, 2005 at 01:05:49PM +0200, Marcel Holtmann wrote:
> > Hi Al,
> >
> > > Bluetooth HIDP selects INPUT and it really needs it to be
> > > there - module depends on input core. And input core is never
> > > built on s390... Marked as broken on s390, for now; if somebody
> > > has better ideas, feel free to fix it and remove dependency...
> > >
> > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> >
> > basically I think someone should fix the input layer on S390, but I am
> > fine with your fix.
And since there isn't a Bluetooth device on s390 (yet), we can live with
the broken input core for now. Would be nicer if the input layer would
work but there are more important things..
> There's a problem with that patch, though ;-/ S390 is never defined by
> arch/s390/Kconfig; ARCH_S390 is. From the fast grep it looks like there
> is one more place with the same problem: drivers/char/Kconfig has
> config HW_CONSOLE
> bool
> depends on VT && !S390 && !UML
> default y
> and the second term is always true here. Why do we have that dependency,
> anyway, when s390 doesn't include drivers/char/Kconfig at all?
.. e.g. this one. I tried to cleanup the Kconfig for s390 once. After
the patch has grown over 2000 lines of code I gave up. If you have the
feeling that this should be fixed I'll give it another try. At least the
issue with ARCH_S390/ARCH_S390X vs. S390/S390_64 should be fixed.
--
blue skies,
Martin
Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
prev parent reply other threads:[~2005-10-31 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 11:02 [PATCH] bluetooth hidp is broken on s390 Al Viro
2005-10-29 11:05 ` Marcel Holtmann
2005-10-29 18:47 ` Al Viro
2005-10-31 9:01 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130749260.5863.12.camel@localhost.localdomain \
--to=schwidefsky@de.ibm.com \
--cc=dtor@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox