From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: David Brownell <david-b@pacbell.net>,
linux-usb-devel@lists.sourceforge.net,
Alan Stern <stern@rowland.harvard.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] Re: Commit "[PATCH] USB: Always do usb-handoff" breaks my powerbook
Date: Tue, 01 Nov 2005 16:08:04 +1100 [thread overview]
Message-ID: <1130821684.29054.434.camel@gaston> (raw)
In-Reply-To: <17254.62622.780185.729677@cargo.ozlabs.ibm.com>
On Tue, 2005-11-01 at 15:52 +1100, Paul Mackerras wrote:
> David Brownell writes:
>
> > Maybe you should first pay attention to what I pointed out: that
> > the problem reports I've seen have ONLY been on PPC systems.
>
> Well, there is a problem in the code which is clearly visible just by
> inspection: that it is touching a pci device without having called
> pci_enable_device on it. That is well known to cause problems on many
> platforms, and it is not guaranteed to work on any platform.
>
> With a clearly visible bug like that in there, it doesn't matter what
> platform(s) the problem is reported on.
Yup, though I agree that considering the purpose of that code, it might
make sense for it to just "peek" to check if the device was enabled
rather than force-enabling it. If it was not, there is obviously no
handoff to do from the BIOS.
Ben.
next prev parent reply other threads:[~2005-11-01 5:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 5:23 Commit "[PATCH] USB: Always do usb-handoff" breaks my powerbook Paul Mackerras
2005-11-01 0:16 ` Benjamin Herrenschmidt
2005-11-01 1:41 ` [linux-usb-devel] " David Brownell
2005-11-01 2:41 ` Benjamin Herrenschmidt
2005-11-01 3:09 ` David Brownell
2005-11-01 3:30 ` Benjamin Herrenschmidt
2005-11-01 4:17 ` David Brownell
2005-11-01 4:52 ` Paul Mackerras
2005-11-01 5:08 ` Benjamin Herrenschmidt [this message]
2005-11-01 9:28 ` Alan Cox
2005-11-01 13:40 ` Glenn Maynard
2005-11-01 21:09 ` Benjamin Herrenschmidt
2005-11-01 3:39 ` Dmitry Torokhov
2005-11-01 4:06 ` Kyle Moffett
2005-11-01 4:39 ` David Brownell
-- strict thread matches above, loose matches on Subject: below --
2005-11-02 4:21 Aleksey Gorelov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130821684.29054.434.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=paulus@samba.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox