From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Paul Mackerras <paulus@samba.org>,
akpm@osdl.org, David Brownell <david-b@pacbell.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't touch USB controllers with MMIO disabled in quirks
Date: Thu, 03 Nov 2005 08:13:54 +1100 [thread overview]
Message-ID: <1130966034.20136.52.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.64.0511010748430.27915@g5.osdl.org>
> But an alternative strategy (which might be very sensible) is to forget
> about the handoff entirely, and just shut down the bus master flag
> unconditionally. Just make sure that the eventual driver will reset the
> controller before it re-enables bus mastering.
Unfortunately, I know quite a few devices (including USB controllers)
that will react badly to the bus master flag being just cleared like
that. By badly, I mean it ranges from simply ignoring it and happily
continuing whatever bus master was being done, to completely screwing up
and crapping all over your memory/bus.
> That would seem to be the simplest possible "handoff". The only danger is
> that I could imagine that there would be controllers out there that get
> really confused (ie "I'm not going to play nice any more") if we shut them
> up that way.
I suspect with the IO/MEM enable test fix we did, it shoul work fine in
practice for all cases. Let's address the "potential" issues if they
happen to show up in real life, which I doubt.
Ben.
next prev parent reply other threads:[~2005-11-02 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 4:03 [PATCH] Don't touch USB controllers with MMIO disabled in quirks Paul Mackerras
2005-11-01 4:33 ` Linus Torvalds
2005-11-01 4:48 ` Paul Mackerras
2005-11-01 15:32 ` Alan Stern
2005-11-01 15:54 ` Linus Torvalds
2005-11-01 16:43 ` Alan Stern
2005-11-02 21:13 ` Benjamin Herrenschmidt [this message]
2005-11-01 4:50 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130966034.20136.52.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox