From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: Fwd: [RFC] IRQ type flags
Date: Mon, 07 Nov 2005 00:03:22 +0000 [thread overview]
Message-ID: <1131321802.1212.75.camel@localhost.localdomain> (raw)
In-Reply-To: <20051106224225.GC6274@flint.arm.linux.org.uk>
On Sul, 2005-11-06 at 22:42 +0000, Russell King wrote:
> We could do as you suggest, but my concern would be adding extra
> complexity to drivers, causing them to do something like:
>
> ret = request_irq(..., SA_TRIGGER_HIGH, ...);
> if (ret == -E<whatever>)
> ret = request_irq(..., SA_TRIGGER_RISING, ...);
>
> The alternative is:
>
> ret = request_irq(..., SA_TRIGGER_HIGH | SA_TRIGGER_RISING, ...);
I was thinking that specifying neither would imply 'don't care' or
'system default'. That would mean existing drivers just worked and
driver authors who didnt care need take no specific action.
next prev parent reply other threads:[~2005-11-06 23:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-06 8:40 Fwd: [RFC] IRQ type flags Russell King
2005-11-06 22:41 ` Alan Cox
2005-11-06 22:16 ` Russell King
2005-11-06 22:59 ` Alan Cox
2005-11-06 22:42 ` Russell King
2005-11-06 23:33 ` Benjamin Herrenschmidt
2005-11-07 0:03 ` Alan Cox [this message]
2005-11-07 3:40 ` Benjamin Herrenschmidt
2005-11-07 8:51 ` Russell King
2005-11-07 12:42 ` Ben Dooks
2005-11-07 18:10 ` Russell King
2005-12-12 11:47 ` Russell King
2005-12-12 12:01 ` Russell King
2005-12-13 14:49 ` Kumar Gala
2005-12-15 14:44 ` Russell King
2005-12-14 15:48 ` Fwd: " Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131321802.1212.75.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox